Linux-Fsdevel Archive on
help / color / mirror / Atom feed
From: Miklos Szeredi <>
To: Vivek Goyal <>
	virtio-fs-list <>,
	Stefan Hajnoczi <>,
	"Dr. David Alan Gilbert" <>
Subject: Re: [PATCH 0/2] fuse, dax: Couple of fixes for fuse dax support
Date: Fri, 4 Sep 2020 11:45:53 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Sep 1, 2020 at 4:26 PM Vivek Goyal <> wrote:
> Hi Miklos,
> I am testing fuse dax branch now. To begin with here are couple of
> simple fixes to make sure I/O is going through dax path.
> Either you can roll these fixes into existing patches or apply on
> top.
> I ran blogbench workload and some fio mmap jobs and these seem to be
> running fine after these fixes.

Thanks for testing and fixing.

Pushed a rerolled series to #for-next.   Would be good if you cour retest.

There's one checkpatch warning I'm unsure about:

| WARNING: Using vsprintf specifier '%px' potentially exposes the
kernel memory layout, if you don't really need the address please
consider using '%p'.
| #173: FILE: fs/fuse/virtio_fs.c:812:
| +    dev_dbg(&vdev->dev, "%s: window kaddr 0x%px phys_addr 0x%llx
len 0x%llx\n",
| +        __func__, fs->window_kaddr, cache_reg.addr, cache_reg.len);
| total: 0 errors, 1 warnings, 175 lines checked
| NOTE: For some of the reported defects, checkpatch may be able to
|       mechanically convert to the typical style using --fix or --fix-inplace.
| patches/virtio_fs-dax-set-up-virtio_fs-dax_device.patch has style
problems, please review.

Do you think that the kernel address in the debug output is necessary?


  parent reply	other threads:[~2020-09-04  9:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 14:26 Vivek Goyal
2020-09-01 14:26 ` [PATCH 1/2] fuse, dax: Use correct config option CONFIG_FUSE_DAX Vivek Goyal
2020-09-01 14:26 ` [PATCH 2/2] fuse, dax: Save dax device in fuse_conn_dax Vivek Goyal
2020-09-04  9:45 ` Miklos Szeredi [this message]
2020-09-04 13:05   ` [PATCH 0/2] fuse, dax: Couple of fixes for fuse dax support Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \
    --subject='Re: [PATCH 0/2] fuse, dax: Couple of fixes for fuse dax support' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).