From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D147C433DF for ; Fri, 21 Aug 2020 14:47:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E00462075E for ; Fri, 21 Aug 2020 14:47:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="hpiahwg9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727084AbgHUOrA (ORCPT ); Fri, 21 Aug 2020 10:47:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726610AbgHUOq5 (ORCPT ); Fri, 21 Aug 2020 10:46:57 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6572FC061573 for ; Fri, 21 Aug 2020 07:46:57 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id di22so1616625edb.12 for ; Fri, 21 Aug 2020 07:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9GdKxeOACY7uALRLtrv9oRSnF/gGqv6TA6L3Hiy25go=; b=hpiahwg9EH78MVjDWcW2rVaybIwoFsRbpdb0j63ncz9A2OgxnMI6zATzZRAYMsp1Nc x2OugxjWwVfSOPOhbrEQz35nU9ExDSz1+WGWhYI6hahz5uBrkN8c0RhYO6Zw3eYd/Hia bu9mRNzG9ehDQ0B2ekOU+jdtUAAf1KNc37fXI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9GdKxeOACY7uALRLtrv9oRSnF/gGqv6TA6L3Hiy25go=; b=YzFx64rP++x5/tciwrIyzjUsDiwDMuikxPTv7Zl3i21f+7WrUMgI5bUj6yd72ayi5G 1Gp9Jp7ENOuIWPDSTQxxoUcs7MlGhZJmLP407OsX9mrfbRFTY3pbMAAvLLLfQm2UkkrB PwwM+CD3TMk/a5r6MGj6yKmibfmgHJgMNDU5rRK6VU0O6govkxM1ZBocjO4UK6AX62LH XiSZG5lCeN0kDFE4lmjdI4rhSFFZc8m8xqpnwb8bXvOQk4n5r6WqRRwbJueGWrwZs+1g nHrC48t1YYT4MfvxJm/JGsQUa4AX9ybm/DBIFszleGlejOSYSrTM3OIZRqEPrPCQergl S39w== X-Gm-Message-State: AOAM531NK+Li8jROE6ZWRCJJekFPrCzkjnqdbTY98QS3AVIwumF3qAzh 3Z6pdh0RmCk1NjEPvO3Q7MLAl73bqn/XHiTnVtzoLA== X-Google-Smtp-Source: ABdhPJzqm77LyknxHijF41Xfz/AAFhv5zhsEO6ZnZ4Q+smZhb6C2z3AjsF0qcBQfRCapN+qc89LrrauSuRh6vHtl40c= X-Received: by 2002:a05:6402:1bc5:: with SMTP id ch5mr3062650edb.364.1598021215870; Fri, 21 Aug 2020 07:46:55 -0700 (PDT) MIME-Version: 1.0 References: <20200724183812.19573-1-vgoyal@redhat.com> In-Reply-To: <20200724183812.19573-1-vgoyal@redhat.com> From: Miklos Szeredi Date: Fri, 21 Aug 2020 16:46:44 +0200 Message-ID: Subject: Re: [RFC PATCH 0/5] fuse: Implement FUSE_HANDLE_KILLPRIV_V2 and enable SB_NOSEC To: Vivek Goyal Cc: linux-fsdevel@vger.kernel.org, virtio-fs-list Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Jul 24, 2020 at 8:38 PM Vivek Goyal wrote: > If you are concerned about regression w.r.t clear of caps, then we > can think of enabling SB_NOSEC conditionally. Say user chooses it > as mount option. But given caps is just an outlier and currently > we clear suid/sgid based on cache (and not based on state on server), > I feel it might not be a huge issue. > > What do you think? I think enabling xattr caching should be a separate feature, and yes, SB_NOSEC would effectively enable xattr caching. We could add the FUSE_CACHE_XATTR feature flag without actually adding real caching, just SB_NOSEC... Does that sound sane? Thanks, Miklos