Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Chirantan Ekbote <chirantan@chromium.org>
Cc: linux-fsdevel@vger.kernel.org, Dylan Reid <dgreid@chromium.org>,
	Suleiman Souhlal <suleiman@chromium.org>,
	fuse-devel <fuse-devel@lists.sourceforge.net>
Subject: Re: [PATCH] fuse: Fix parameter for FS_IOC_{GET,SET}FLAGS
Date: Wed, 15 Jul 2020 14:20:15 +0200	[thread overview]
Message-ID: <CAJfpegvd3nHWLtxjeC8BfW8JTHKRmX5iNgdWYYFj+MEK-ogiFw@mail.gmail.com> (raw)
In-Reply-To: <20200714102639.662048-1-chirantan@chromium.org>

On Tue, Jul 14, 2020 at 12:26 PM Chirantan Ekbote
<chirantan@chromium.org> wrote:
>
> The ioctl encoding for this parameter is a long but the documentation
> says it should be an int and the kernel drivers expect it to be an int.
> If the fuse driver treats this as a long it might end up scribbling over
> the stack of a userspace process that only allocated enough space for an
> int.
>
> This was previously discussed in [1] and a patch for fuse was proposed
> in [2].  From what I can tell the patch in [2] was nacked in favor of
> adding new, "fixed" ioctls and using those from userspace.  However
> there is still no "fixed" version of these ioctls and the fact is that
> it's sometimes infeasible to change all userspace to use the new one.

Okay, applied.

Funny that no one came back with this issue for 7 years.

Thanks,
Miklos

  reply	other threads:[~2020-07-15 12:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 10:26 Chirantan Ekbote
2020-07-15 12:20 ` Miklos Szeredi [this message]
2020-07-15 23:06   ` Sedat Dilek
2020-07-16  5:17     ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJfpegvd3nHWLtxjeC8BfW8JTHKRmX5iNgdWYYFj+MEK-ogiFw@mail.gmail.com \
    --to=miklos@szeredi.hu \
    --cc=chirantan@chromium.org \
    --cc=dgreid@chromium.org \
    --cc=fuse-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=suleiman@chromium.org \
    --subject='Re: [PATCH] fuse: Fix parameter for FS_IOC_{GET,SET}FLAGS' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).