Linux-Fsdevel Archive on
help / color / mirror / Atom feed
From: Miguel Ojeda <>
To: Nick Desaulniers <>
Cc: Alexander Viro <>,
	Masahiro Yamada <>,
	Guenter Roeck <>,
	linux-fsdevel <>,
	linux-kernel <>,
	linux-alpha <>
Subject: Re: [PATCH] fs: binfmt_em86: check return code of remove_arg_zero
Date: Wed, 6 Jan 2021 03:57:59 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Dec 22, 2020 at 10:03 PM Nick Desaulniers
<> wrote:
> remove_arg_zero is declared as __must_check. Looks like it can return
> -EFAULT on failure.
> Cc: Masahiro Yamada <>
> Cc: Miguel Ojeda <>
> Reported-by: Guenter Roeck <>
> Signed-off-by: Nick Desaulniers <>

Cc'ing Alpha list too.

Alexander, fs-devel: pinging about this... We removed
ENABLE_MUST_CHECK in 196793946264 ("Compiler Attributes: remove
CONFIG_ENABLE_MUST_CHECK"), so this should be giving a warning now
unconditionally. In 5.12 it will likely become a build error.

Nick: thanks for the patch! (I missed it in December, sorry)

Reviewed-by: Miguel Ojeda <>


      reply	other threads:[~2021-01-06  2:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2020-12-22 21:03 ` Nick Desaulniers
2021-01-06  2:57   ` Miguel Ojeda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] fs: binfmt_em86: check return code of remove_arg_zero' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).