Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michael Thayer <michael.thayer@oracle.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Christoph Hellwig <hch@infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf) support
Date: Mon, 15 Jan 2018 22:22:32 +0200	[thread overview]
Message-ID: <CAOQ4uxisUyjK-g8SjYNhHZaGgLj8h57KbEPYA7jYFPxXRbwpDA@mail.gmail.com> (raw)
In-Reply-To: <86fa6f42-7993-ff56-45a5-85f89f9370ae@redhat.com>

On Mon, Jan 15, 2018 at 9:41 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
>
> On 15-01-18 20:32, Amir Goldstein wrote:
>>
>> On Mon, Jan 15, 2018 at 7:51 PM, Hans de Goede <hdegoede@redhat.com>
>> wrote:
>>>
>>> VirtualBox hosts can share folders with guests, this commit adds a
>>> VFS driver implementing the Linux-guest side of this, allowing folders
>>> exported by the host to be mounted under Linux.
>>>
>>> This driver depends on the guest <-> host IPC functions exported by
>>> the vboxguest driver.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>> ---
>>>   fs/Kconfig                     |   1 +
>>>   fs/Makefile                    |   1 +
>>>   fs/vboxsf/Kconfig              |   9 +
>>>   fs/vboxsf/Makefile             |   3 +
>>>   fs/vboxsf/dir.c                | 648 +++++++++++++++++++++++++++++
>>>   fs/vboxsf/file.c               | 416 +++++++++++++++++++
>>>   fs/vboxsf/shfl_hostintf.h      | 919
>>> +++++++++++++++++++++++++++++++++++++++++
>>>   fs/vboxsf/super.c              | 430 +++++++++++++++++++
>>>   fs/vboxsf/utils.c              | 589 ++++++++++++++++++++++++++
>>>   fs/vboxsf/vboxsf_wrappers.c    | 365 ++++++++++++++++
>>>   fs/vboxsf/vboxsf_wrappers.h    |  46 +++
>>>   fs/vboxsf/vfsmod.h             | 104 +++++
>>>   include/uapi/linux/vbsfmount.h |  62 +++
>>>   13 files changed, 3593 insertions(+)
>>>   create mode 100644 fs/vboxsf/Kconfig
>>>   create mode 100644 fs/vboxsf/Makefile
>>>   create mode 100644 fs/vboxsf/dir.c
>>>   create mode 100644 fs/vboxsf/file.c
>>>   create mode 100644 fs/vboxsf/shfl_hostintf.h
>>>   create mode 100644 fs/vboxsf/super.c
>>>   create mode 100644 fs/vboxsf/utils.c
>>>   create mode 100644 fs/vboxsf/vboxsf_wrappers.c
>>>   create mode 100644 fs/vboxsf/vboxsf_wrappers.h
>>>   create mode 100644 fs/vboxsf/vfsmod.h
>>>   create mode 100644 include/uapi/linux/vbsfmount.h
>>
>>
[...]
>>> +++ b/fs/vboxsf/Kconfig
>>> @@ -0,0 +1,9 @@
>>> +config VBOXSF_FS
>>> +       tristate "VirtualBox guest shared folder (vboxsf) support"
>>
>>
>>
>> Don't know if you noticed, but calling your filesystem vboxsf
>> is quite odd name among other XXXfs beasts.
>
>
> Yes I noticed, note I'm only the guy pushing this upstream this code
> has a long out-of-tree history. FWIW the sf stand for "shared folder"
>
>> Will it be an option to re-brand this as vboxfs?
>> Even if it is too late or too much of a hustle to change the user visible
>> file_system_type name, I think changing the internal name is worth it.
>
>
> We can quite definitely not change the user-visible name, the mount
> arg changes Christoph Hellwig has requested are tricky enough wrt
> compatibility with the out-of-tree version most users use atm.
>
> The users will need updated userspace tools to deal with the mount arg
> changes, but that is as easy as checking for -EINVAL and trying again
> with the new style string args. But figuring out the right fstype name
> is rather more tricky and the mount binary name has been mount.vboxsf
> for ages...  So I would really like to keep the file_system_type name
> as vboxsf, at which point it seems counter-productive to me to rename
> the files / kernel-mode to vboxfs.
>

Well, its up to you and whoever merges this code, but I don't find this
rename counter-productive at all. Isn't the idea behind becoming an in-tree
fs, conforming to the way we do things in-the-tree?

Someone at Oracle once made a decision sometime in the past when that
code was out of tree and not among other fs without conforming to in-tree
standards. That decision affects the user visible fs name and I wasn't
suggesting to change that. That is what MODULE_ALIAS_FS is for.
But there is not really a good reason to carry the baggage of this decision
into the tree.

I don't know, maybe it's just me...

Cheers,
Amir.

  reply	other threads:[~2018-01-15 20:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 17:51 [PATCH v2 0/1] " Hans de Goede
2018-01-15 17:51 ` [PATCH v2] " Hans de Goede
2018-01-15 17:55   ` Christoph Hellwig
2018-01-15 18:01     ` Hans de Goede
2018-01-15 19:32   ` Amir Goldstein
2018-01-15 19:41     ` Hans de Goede
2018-01-15 20:22       ` Amir Goldstein [this message]
2018-01-15 22:36   ` Al Viro
2018-01-16 10:15     ` Hans de Goede
2018-01-17  3:19       ` Al Viro
2018-01-17 10:45         ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxisUyjK-g8SjYNhHZaGgLj8h57KbEPYA7jYFPxXRbwpDA@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.thayer@oracle.com \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf) support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).