Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] zonefs: add zone-capacity support
Date: Mon, 20 Jul 2020 12:36:49 +0000	[thread overview]
Message-ID: <SN4PR0401MB3598A4C053BAD3B93BB873D19B7B0@SN4PR0401MB3598.namprd04.prod.outlook.com> (raw)
In-Reply-To: <CY4PR04MB37519A139219C1D788BCA048E77B0@CY4PR04MB3751.namprd04.prod.outlook.com>

On 20/07/2020 14:34, Damien Le Moal wrote:
[...]
>> +				zone->capacity += next->capacity;
>>  				if (next->cond == BLK_ZONE_COND_READONLY &&
>>  				    zone->cond != BLK_ZONE_COND_OFFLINE)
>>  					zone->cond = BLK_ZONE_COND_READONLY;
>>  				else if (next->cond == BLK_ZONE_COND_OFFLINE)
>>  					zone->cond = BLK_ZONE_COND_OFFLINE;
>>  			}
>> +			if (zone->capacity != zone->len) {
>> +				zonefs_err(sb, "Invalid conventional zone capacity\n");
>> +				ret = -EINVAL;
> 
> Need "goto free;" here. Forgot it too in the code snippet I sent..
> 

Oh right sorry for missing it.

  reply	other threads:[~2020-07-20 12:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20 12:29 [PATCH v3 0/2] zonefs: add support zone capacity support Johannes Thumshirn
2020-07-20 12:29 ` [PATCH v3 1/2] zonefs: add zone-capacity support Johannes Thumshirn
2020-07-20 12:34   ` Damien Le Moal
2020-07-20 12:36     ` Johannes Thumshirn [this message]
2020-07-20 12:29 ` [PATCH v3 2/2] zonefs: update documentation to reflect zone size vs capacity Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN4PR0401MB3598A4C053BAD3B93BB873D19B7B0@SN4PR0401MB3598.namprd04.prod.outlook.com \
    --to=johannes.thumshirn@wdc.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --subject='Re: [PATCH v3 1/2] zonefs: add zone-capacity support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).