Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Ritesh Harjani <riteshh@linux.ibm.com>, linux-block@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, hch@infradead.org,
Shivaprasad G Bhat <sbhat@linux.ibm.com>,
Anju T Sudhakar <anju@linux.vnet.ibm.com>
Subject: Re: [RESEND PATCH 1/1] block: Set same_page to false in __bio_try_merge_page if ret is false
Date: Wed, 9 Sep 2020 08:19:07 -0600 [thread overview]
Message-ID: <a90e9ab8-93b5-8ea0-97fb-2d5ea90196b1@kernel.dk> (raw)
In-Reply-To: <bfee107c7d1075cab6ec297afbd3ace68955b836.1599620898.git.riteshh@linux.ibm.com>
On 9/8/20 9:14 PM, Ritesh Harjani wrote:
> If we hit the UINT_MAX limit of bio->bi_iter.bi_size and so we are anyway
> not merging this page in this bio, then it make sense to make same_page
> also as false before returning.
>
> Without this patch, we hit below WARNING in iomap.
> This mostly happens with very large memory system and / or after tweaking
> vm dirty threshold params to delay writeback of dirty data.
>
> WARNING: CPU: 18 PID: 5130 at fs/iomap/buffered-io.c:74 iomap_page_release+0x120/0x150
> CPU: 18 PID: 5130 Comm: fio Kdump: loaded Tainted: G W 5.8.0-rc3 #6
> Call Trace:
> __remove_mapping+0x154/0x320 (unreliable)
> iomap_releasepage+0x80/0x180
> try_to_release_page+0x94/0xe0
> invalidate_inode_page+0xc8/0x110
> invalidate_mapping_pages+0x1dc/0x540
> generic_fadvise+0x3c8/0x450
> xfs_file_fadvise+0x2c/0xe0 [xfs]
> vfs_fadvise+0x3c/0x60
> ksys_fadvise64_64+0x68/0xe0
> sys_fadvise64+0x28/0x40
> system_call_exception+0xf8/0x1c0
> system_call_common+0xf0/0x278
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-09-09 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 3:14 Ritesh Harjani
2020-09-09 3:36 ` Ming Lei
2020-09-09 6:01 ` Christoph Hellwig
2020-09-09 14:19 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a90e9ab8-93b5-8ea0-97fb-2d5ea90196b1@kernel.dk \
--to=axboe@kernel.dk \
--cc=anju@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=sbhat@linux.ibm.com \
--subject='Re: [RESEND PATCH 1/1] block: Set same_page to false in __bio_try_merge_page if ret is false' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).