From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com ([209.85.128.65]:34958 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725440AbeLTPcL (ORCPT ); Thu, 20 Dec 2018 10:32:11 -0500 Received: by mail-wm1-f65.google.com with SMTP id c126so2657312wmh.0 for ; Thu, 20 Dec 2018 07:32:10 -0800 (PST) Subject: Re: [PATCH] fs: Return EOPNOTSUPP if block layer does not support REQ_NOWAIT To: Goldwyn Rodrigues , Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org References: <20181213115306.fm2mjc3qszjiwkgf@merlin> <38b8f7a9-cf95-e165-4e9a-40ddcfe6bed2@scylladb.com> <20181213142434.GA3239@infradead.org> <0bafdaea-a787-fadb-5da8-06b9e0042840@scylladb.com> <20181217173813.GB10437@infradead.org> <20181218115524.lt3dm53vgmbdbxjd@merlin> From: Avi Kivity Message-ID: Date: Thu, 20 Dec 2018 17:32:06 +0200 MIME-Version: 1.0 In-Reply-To: <20181218115524.lt3dm53vgmbdbxjd@merlin> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 12/18/18 1:55 PM, Goldwyn Rodrigues wrote: > On 9:38 17/12, Christoph Hellwig wrote: >> On Sun, Dec 16, 2018 at 12:45:19PM +0200, Avi Kivity wrote: >>> I did see this on XFS too. The whole thing bothers me, it doesn't happen >>> consistently in some setups, which I don't understand. Either it should >>> trigger always or never. >> Well, if it also happens in XFS the above change isn't going to fix >> it alone, there must be another issue hiding in addition to the error >> conversion problems. > Are you using multi-device setup as your block device? That could make > it return EOPNOTSUPP since we never got to a point where we could > merge code which supported bio based devices. > Yes, an lvm linear device on top of a single SATA SSD.