Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Andreas Gruenbacher <agruenba@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>,
	Dave Chinner <david@fromorbit.com>,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC v3 1/2] fs: Add IOCB_NOIO flag for generic_file_read_iter
Date: Tue, 7 Jul 2020 12:39:29 -0600	[thread overview]
Message-ID: <e49c5a2b-866f-14ae-9665-284726815bbd@kernel.dk> (raw)
In-Reply-To: <20200707144457.1603400-2-agruenba@redhat.com>

On 7/7/20 8:44 AM, Andreas Gruenbacher wrote:
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 3f881a892ea7..1ab2ea19e883 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -315,6 +315,7 @@ enum rw_hint {
>  #define IOCB_SYNC		(1 << 5)
>  #define IOCB_WRITE		(1 << 6)
>  #define IOCB_NOWAIT		(1 << 7)
> +#define IOCB_NOIO		(1 << 8)

Just to make this even more trivial in terms of merge conflicts, could
you do 1 << 9 instead?

-- 
Jens Axboe


  reply	other threads:[~2020-07-07 18:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 14:44 [RFC v3 0/2] Fix gfs2 readahead deadlocks Andreas Gruenbacher
2020-07-07 14:44 ` [RFC v3 1/2] fs: Add IOCB_NOIO flag for generic_file_read_iter Andreas Gruenbacher
2020-07-07 18:39   ` Jens Axboe [this message]
2020-07-07 21:42     ` Andreas Grünbacher
2020-07-07 14:44 ` [RFC v3 2/2] gfs2: Rework read and page fault locking Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e49c5a2b-866f-14ae-9665-284726815bbd@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=agruenba@redhat.com \
    --cc=david@fromorbit.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@linux-foundation.org \
    --cc=willy@infradead.org \
    --subject='Re: [RFC v3 1/2] fs: Add IOCB_NOIO flag for generic_file_read_iter' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).