Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@zeniv.linux.org.uk, Avi Kivity <avi@scylladb.com>,
	linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
	netdev@vger.kernel.org, linux-api@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: aio poll, io_pgetevents and a new in-kernel poll API V3
Date: Thu, 18 Jan 2018 11:44:03 -0500	[thread overview]
Message-ID: <x497esfunfw.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <x49bmhruq3k.fsf@segfault.boston.devel.redhat.com> (Jeff Moyer's message of "Thu, 18 Jan 2018 10:46:39 -0500")

Jeff Moyer <jmoyer@redhat.com> writes:

> FYI, this kernel has issues.  It will boot up, but I don't have
> networking, and even rebooting doesn't succeed.  I'm looking into it.

A bisect lands on: eventfd: switch to ->poll_mask.  That's not super
helpful, though.  I did run the ltp eventfd2 tests, and they all pass.

The actual issue I get on boot is that several services don't start:

[FAILED] Failed to start Modem Manager.
See 'systemctl status ModemManager.service' for details.
[FAILED] Failed to start Authorization Manager.
See 'systemctl status polkit.service' for details.
[DEPEND] Dependency failed for Dynamic System Tuning Daemon.
[FAILED] Failed to start Network Manager.
See 'systemctl status NetworkManager.service' for details.
[DEPEND] Dependency failed for Network Manager Wait Online.
...

Christoph, are you able to reproduce this?

-Jeff

> Christoph Hellwig <hch@lst.de> writes:
>
>> Hi all,
>>
>> this series adds support for the IOCB_CMD_POLL operation to poll for the
>> readyness of file descriptors using the aio subsystem.  The API is based
>> on patches that existed in RHAS2.1 and RHEL3, which means it already is
>> supported by libaio.  To implement the poll support efficiently new
>> methods to poll are introduced in struct file_operations:  get_poll_head
>> and poll_mask.  The first one returns a wait_queue_head to wait on
>> (lifetime is bound by the file), and the second does a non-blocking
>> check for the POLL* events.  This allows aio poll to work without
>> any additional context switches, unlike epoll.
>>
>> To make the interface fully useful a new io_pgetevents system call is
>> added, which atomically saves and restores the signal mask over the
>> io_pgetevents system call.  It it the logical equivalent to pselect and
>> ppoll for io_pgetevents.
>>
>> The corresponding libaio changes for io_pgetevents support and
>> documentation, as well as a test case will be posted in a separate
>> series.
>>
>> The changes were sponsored by Scylladb, and improve performance
>> of the seastar framework up to 10%, while also removing the need
>> for a privileged SCHED_FIFO epoll listener thread.
>>
>> The patches are on top of Als __poll_t annoations, so I've also
>> prepared a git branch on top of those here:
>>
>>     git://git.infradead.org/users/hch/vfs.git aio-poll.3
>>
>> Gitweb:
>>
>>     http://git.infradead.org/users/hch/vfs.git/shortlog/refs/heads/aio-poll.3
>>
>> Libaio changes:
>>
>>     https://pagure.io/libaio.git io-poll
>>
>> Seastar changes (not updated for the new io_pgetevens ABI yet):
>>
>>     https://github.com/avikivity/seastar/commits/aio
>>
>> Changes since V2:
>>  - removed a double initialization
>>  - new vfs_get_poll_head helper
>>  - document that ->get_poll_head can return NULL
>>  - call ->poll_mask before sleeping
>>  - various ACKs
>>  - add conversion of random to ->poll_mask
>>  - add conversion of af_alg to ->poll_mask
>>  - lacking ->poll_mask support now returns -EINVAL for IOCB_CMD_POLL
>>  - reshuffled the series so that prep patches and everything not
>>    requiring the new in-kernel poll API is in the beginning
>>
>> Changes since V1:
>>  - handle the NULL ->poll case in vfs_poll
>>  - dropped the file argument to the ->poll_mask socket operation
>>  - replace the ->pre_poll socket operation with ->get_poll_head as
>>    in the file operations
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-aio' in
>> the body to majordomo@kvack.org.  For more info on Linux AIO,
>> see: http://www.kvack.org/aio/
>> Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-aio' in
> the body to majordomo@kvack.org.  For more info on Linux AIO,
> see: http://www.kvack.org/aio/
> Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>

  reply	other threads:[~2018-01-18 16:44 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17 19:27 Christoph Hellwig
2018-01-17 19:27 ` [PATCH 01/36] aio: don't print the page size at boot time Christoph Hellwig
2018-01-17 19:27 ` [PATCH 02/36] aio: remove an outdated comment in aio_complete Christoph Hellwig
2018-01-17 19:27 ` [PATCH 03/36] aio: refactor read/write iocb setup Christoph Hellwig
2018-01-17 19:27 ` [PATCH 04/36] aio: sanitize ki_list handling Christoph Hellwig
2018-01-17 19:27 ` [PATCH 05/36] aio: simplify cancellation Christoph Hellwig
2018-01-17 19:27 ` [PATCH 06/36] aio: delete iocbs from the active_reqs list in kiocb_cancel Christoph Hellwig
2018-01-17 19:27 ` [PATCH 07/36] aio: add delayed cancel support Christoph Hellwig
2018-01-17 19:27 ` [PATCH 08/36] aio: implement io_pgetevents Christoph Hellwig
2018-01-17 19:27 ` [PATCH 09/36] fs: unexport poll_schedule_timeout Christoph Hellwig
2018-01-17 19:27 ` [PATCH 10/36] fs: cleanup do_pollfd Christoph Hellwig
2018-01-17 19:27 ` [PATCH 11/36] fs: update documentation for __poll_t Christoph Hellwig
2018-01-17 19:27 ` [PATCH 12/36] fs: add new vfs_poll and file_can_poll helpers Christoph Hellwig
2018-01-17 19:27 ` [PATCH 13/36] fs: introduce new ->get_poll_head and ->poll_mask methods Christoph Hellwig
2018-01-17 19:27 ` [PATCH 14/36] aio: implement IOCB_CMD_POLL Christoph Hellwig
2018-01-17 19:27 ` [PATCH 15/36] net: refactor socket_poll Christoph Hellwig
2018-01-17 19:27 ` [PATCH 16/36] net: add support for ->poll_mask in proto_ops Christoph Hellwig
2018-01-17 19:27 ` [PATCH 17/36] net: remove sock_no_poll Christoph Hellwig
2018-01-17 19:27 ` [PATCH 18/36] net/tcp: convert to ->poll_mask Christoph Hellwig
2018-01-17 19:27 ` [PATCH 19/36] net/unix: " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 20/36] net: convert datagram_poll users tp ->poll_mask Christoph Hellwig
2018-01-17 19:27 ` [PATCH 21/36] net/dccp: convert to ->poll_mask Christoph Hellwig
2018-01-17 19:27 ` [PATCH 22/36] net/atm: " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 23/36] net/vmw_vsock: " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 24/36] net/tipc: " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 25/36] net/sctp: " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 26/36] net/bluetooth: " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 27/36] net/caif: " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 28/36] net/nfc: " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 29/36] net/phonet: " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 30/36] net/iucv: " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 31/36] net/rxrpc: " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 32/36] crypto: af_alg: " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 33/36] pipe: " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 34/36] eventfd: switch " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 35/36] timerfd: convert " Christoph Hellwig
2018-01-17 19:27 ` [PATCH 36/36] random: " Christoph Hellwig
2018-01-18 15:46 ` aio poll, io_pgetevents and a new in-kernel poll API V3 Jeff Moyer
2018-01-18 16:44   ` Jeff Moyer [this message]
2018-01-18 17:42     ` Christoph Hellwig
2018-01-18 17:59       ` Jeff Moyer
2018-01-18 17:55     ` Colin Walters
2018-01-18 18:53       ` Christoph Hellwig
2018-01-18 17:51   ` Avi Kivity
2018-01-18 17:52     ` Avi Kivity
2018-01-18 17:54     ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x497esfunfw.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=avi@scylladb.com \
    --cc=hch@lst.de \
    --cc=linux-aio@kvack.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: aio poll, io_pgetevents and a new in-kernel poll API V3' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).