LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Zhenmin Li" <zli4@cs.uiuc.edu>
To: <linux-kernel@vger.kernel.org>
Subject: [OPERA] Potential bug in /arch/sparc/prom/memory.c &  /arch/sparc64/prom/memory.c
Date: Wed, 19 May 2004 21:45:03 -0500	[thread overview]
Message-ID: <001201c43e14$73e8c840$76f6ae80@Turandot> (raw)

We ran our bug detection tool upon Linux 2.6.6, and found some potential
errors. We would sincerely appreciate your help if anyone can confirm
whether they are bugs or not.

Linux 2.6.6, /arch/sparc/prom/memory.c, Line 153-160

153    for(iter=0; iter<num_regs; iter++) {
154            prom_prom_taken[iter].start_adr =
155                    (char *) prom_reg_memlist[iter].phys_addr;
156            prom_prom_taken[iter].num_bytes =
157                    (unsigned long) prom_reg_memlist[iter].reg_size;
158            prom_prom_taken[iter].theres_more =
!159                    &prom_phys_total[iter+1];
160    }

May be changeg to:

153    for(iter=0; iter<num_regs; iter++) {
154            prom_prom_taken[iter].start_adr =
155                    (char *) prom_reg_memlist[iter].phys_addr;
156            prom_prom_taken[iter].num_bytes =
157                    (unsigned long) prom_reg_memlist[iter].reg_size;
158            prom_prom_taken[iter].theres_more =
!159                    & prom_prom_taken[iter+1];
160    }


The same bug is in /arch/sparc64/prom/memory.c, Line 111-118.


Thanks a lot,
OPERA Research Group
University of Illinois at Urbana-Champaign



             reply	other threads:[~2004-05-20  2:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-20  2:45 Zhenmin Li [this message]
2004-05-20  3:57 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001201c43e14$73e8c840$76f6ae80@Turandot' \
    --to=zli4@cs.uiuc.edu \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [OPERA] Potential bug in /arch/sparc/prom/memory.c &  /arch/sparc64/prom/memory.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).