LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Chintan Patel <chintan.m.patel@intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH v2 1/3] ASoC: topology: Improve backwards compatibility with v4 topology files
Date: Fri, 1 Jun 2018 06:17:05 -0700 [thread overview]
Message-ID: <0015aace-fe32-9707-d3c9-0dea6f5fc48c@roeck-us.net> (raw)
In-Reply-To: <20180601102506.GB8677@sirena.org.uk>
On 06/01/2018 03:25 AM, Mark Brown wrote:
> On Thu, May 24, 2018 at 12:49:21PM -0700, Guenter Roeck wrote:
>> From: Guenter Roeck <groeck@chromium.org>
>>
>> Commit dc31e741db49 ("ASoC: topology: ABI - Add the types for BE
>> DAI") introduced sound topology files version 5. Initially, this
>> change made the topology code incompatible with v4 topology files.
>
> No review on these from anyone at Intel?
>
The only actionable feedback I have seen is that the header file
changes should be in uapi, which is done in patches 2 and 3.
Other than that, there was a question if this is a Linux issue or
a Chromebook issue (it appears that only Chromebooks shipped with
v4 configuration files). I took that as rhetorical since upstream
kernels (at least v4.4 and v4.5) support topology v4 configuration
files, and it should not matter which products shipped using those.
Guenter
next prev parent reply other threads:[~2018-06-01 13:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 19:49 [PATCH v2 1/3] ASoC: topology: Improve backwards compatibility with v4 topology files Guenter Roeck
2018-05-24 19:49 ` [PATCH v2 2/3] ASoC: topology: Move v4 manifest header data structures to uapi Guenter Roeck
2018-05-29 7:51 ` [alsa-devel] " Lin, Mengdong
2018-06-01 17:12 ` Applied "ASoC: topology: Move v4 manifest header data structures to uapi" to the asoc tree Mark Brown
2018-05-24 19:49 ` [PATCH v2 3/3] ASoC: topology: Move skl-tplg-interface.h to uapi Guenter Roeck
2018-06-01 17:12 ` Applied "ASoC: topology: Move skl-tplg-interface.h to uapi" to the asoc tree Mark Brown
2018-05-25 13:33 ` [alsa-devel] [PATCH v2 1/3] ASoC: topology: Improve backwards compatibility with v4 topology files Shreyas NC
2018-05-28 6:03 ` Vinod
2018-05-28 6:38 ` Guenter Roeck
2018-06-01 10:25 ` Mark Brown
2018-06-01 13:17 ` Guenter Roeck [this message]
2018-06-01 15:19 ` [alsa-devel] " Pierre-Louis Bossart
2018-06-01 15:55 ` Guenter Roeck
2018-06-01 17:08 ` Mark Brown
2018-06-06 20:29 ` Pierre-Louis Bossart
2018-06-01 17:11 ` Mark Brown
2018-06-01 17:12 ` Applied "ASoC: topology: Improve backwards compatibility with v4 topology files" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0015aace-fe32-9707-d3c9-0dea6f5fc48c@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=chintan.m.patel@intel.com \
--cc=groeck@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).