From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=CHARSET_FARAWAY_HEADER, FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10452C282DD for ; Fri, 24 May 2019 03:23:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB70D2075D for ; Fri, 24 May 2019 03:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731854AbfEXDXH (ORCPT ); Thu, 23 May 2019 23:23:07 -0400 Received: from emcscan.emc.com.tw ([192.72.220.5]:40852 "EHLO emcscan.emc.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729972AbfEXDXG (ORCPT ); Thu, 23 May 2019 23:23:06 -0400 X-Greylist: delayed 588 seconds by postgrey-1.27 at vger.kernel.org; Thu, 23 May 2019 23:23:05 EDT X-IronPort-AV: E=Sophos;i="5.56,253,1539619200"; d="scan'208";a="30739610" Received: from unknown (HELO webmail.emc.com.tw) ([192.168.10.1]) by emcscan.emc.com.tw with SMTP; 24 May 2019 11:13:14 +0800 Received: from 192.168.10.23 by webmail.emc.com.tw with MailAudit ESMTP Server V5.0(174508:0:AUTH_RELAY) (envelope-from ); Fri, 24 May 2019 11:13:13 +0800 (CST) Received: from 192.168.81.85 by webmail.emc.com.tw with Mail2000 ESMTPA Server V7.00(119328:0:AUTH_LOGIN) (envelope-from ); Fri, 24 May 2019 11:13:10 +0800 (CST) From: =?big5?B?ufmxUrph?= To: "'Benjamin Tissoires'" , "'Dmitry Torokhov'" , "'Rob Herring'" , "'Aaron Ma'" , "'Hans de Goede'" Cc: , , References: <20190521132712.2818-1-benjamin.tissoires@redhat.com> <20190521132712.2818-10-benjamin.tissoires@redhat.com> In-Reply-To: <20190521132712.2818-10-benjamin.tissoires@redhat.com> Subject: RE: [PATCH v2 09/10] Input: elan_i2c - correct the width/size base value Date: Fri, 24 May 2019 11:13:10 +0800 Message-ID: <003d01d511de$9da229c0$d8e67d40$@emc.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset="big5" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQMBv+jJqV7WAwqWtnh8gdestIYR9QG8pxropBJQxXA= Content-Language: zh-tw x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcOTIwNzNcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy1kYWY4ZjI2OC03ZGQxLTExZTktYjdjYy01YzUxNGY0NmFhNDVcYW1lLXRlc3RcZGFmOGYyNmEtN2RkMS0xMWU5LWI3Y2MtNWM1MTRmNDZhYTQ1Ym9keS50eHQiIHN6PSIxODA1IiB0PSIxMzIwMzE0MTE4OTgyOTk3MjkiIGg9Imhma2hVUXdmZjdmRWhRVTZWeE1pbEI0Ry9Tcz0iIGlkPSIiIGJsPSIwIiBibz0iMSIvPjwvbWV0YT4= x-dg-rorf: true Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Benjamin, Thanks so much for all you do for Elan touchpad. For the width_*, I have a question for it. Our antenna sensors fully occupied the whole touchpad PCB. The Gap between 2 sensors are 7.5 mil (0.19mm). That's why we did not minus one trace. Thanks KT -----Original Message----- From: Benjamin Tissoires [mailto:benjamin.tissoires@redhat.com] Sent: Tuesday, May 21, 2019 9:27 PM To: Dmitry Torokhov; KT Liao; Rob Herring; Aaron Ma; Hans de Goede Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Benjamin Tissoires Subject: [PATCH v2 09/10] Input: elan_i2c - correct the width/size base value *_traces are the number of antennas. width_* is thus the space between 2 antennas. Which means, we should subtract 1 to the number of antennas to divide the touchpad by the number of holes between each antenna. Signed-off-by: Benjamin Tissoires -- new in v2 --- drivers/input/mouse/elan_i2c_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c index 6f4feedb7765..3375eaa9a72e 100644 --- a/drivers/input/mouse/elan_i2c_core.c +++ b/drivers/input/mouse/elan_i2c_core.c @@ -398,8 +398,8 @@ static int elan_query_device_parameters(struct elan_tp_data *data) if (error) return error; } - data->width_x = data->max_x / x_traces; - data->width_y = data->max_y / y_traces; + data->width_x = data->max_x / (x_traces - 1); + data->width_y = data->max_y / (y_traces - 1); if (device_property_read_u32(&client->dev, "touchscreen-x-mm", &x_mm) || -- 2.21.0