LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drivers/mtd/onenand/onenand_base.c unlikely(x) || unlikely(y) => unlikely(x || y)
@ 2008-02-16 17:14 Roel Kluin
2008-02-18 7:48 ` Kyungmin Park
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2008-02-16 17:14 UTC (permalink / raw)
To: kyungmin.park; +Cc: linux-mtd, lkml
Not yet tested.
---
Replace unlikely(x) || unlikely(y) by unlikely(x || y)
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index 8d7d21b..7334b4a 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -1336,7 +1336,7 @@ static int onenand_panic_write(struct mtd_info *mtd, loff_t to, size_t len,
}
/* Reject writes, which are not page aligned */
- if (unlikely(NOTALIGNED(to)) || unlikely(NOTALIGNED(len))) {
+ if (unlikely(NOTALIGNED(to) || NOTALIGNED(len))) {
printk(KERN_ERR "onenand_panic_write: Attempt to write not page aligned data\n");
return -EINVAL;
}
@@ -1466,7 +1466,7 @@ static int onenand_write_ops_nolock(struct mtd_info *mtd, loff_t to,
}
/* Reject writes, which are not page aligned */
- if (unlikely(NOTALIGNED(to)) || unlikely(NOTALIGNED(len))) {
+ if (unlikely(NOTALIGNED(to) || NOTALIGNED(len))) {
printk(KERN_ERR "onenand_write_ops_nolock: Attempt to write not page aligned data\n");
return -EINVAL;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] drivers/mtd/onenand/onenand_base.c unlikely(x) || unlikely(y) => unlikely(x || y)
2008-02-16 17:14 [PATCH] drivers/mtd/onenand/onenand_base.c unlikely(x) || unlikely(y) => unlikely(x || y) Roel Kluin
@ 2008-02-18 7:48 ` Kyungmin Park
0 siblings, 0 replies; 2+ messages in thread
From: Kyungmin Park @ 2008-02-18 7:48 UTC (permalink / raw)
To: 'Roel Kluin'; +Cc: linux-mtd, 'lkml'
> Not yet tested.
> ---
> Replace unlikely(x) || unlikely(y) by unlikely(x || y)
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Ack-by: Kyungmin Park <kyungmin.park@samsung.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-18 7:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-16 17:14 [PATCH] drivers/mtd/onenand/onenand_base.c unlikely(x) || unlikely(y) => unlikely(x || y) Roel Kluin
2008-02-18 7:48 ` Kyungmin Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).