LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Paul Rolland" <rol@as2917.net>
To: "'Jan Engelhardt'" <jengelh@linux01.gwdg.de>,
	"'Linux Kernel Mailing List'" <linux-kernel@vger.kernel.org>
Cc: "'Andrew Morton'" <akpm@osdl.org>,
	"'Jon Masters'" <jonathan@jonmasters.org>,
	"'Alexey Dobriyan'" <adobriyan@gmail.com>
Subject: RE: [PATCH] Ban module license tag string termination trick
Date: Fri, 2 Feb 2007 15:53:06 +0100	[thread overview]
Message-ID: <011601c746d9$dc5453b0$4b00a8c0@donald> (raw)
In-Reply-To: <Pine.LNX.4.61.0702012147470.1862@yvahk01.tjqt.qr>

Hello,

> will be written to the object file will be "license=GPL\0for 
> nothing\0". 
> When this is interpreted back again in the kernel module 
> loader, it is 
> read as "license=GPL", having circumvented the loading mechanism and 
> having wrongfully access to GPL symbols. According to Alexey [ 
> http://lkml.org/lkml/2006/10/27/233 ], LinuxAnt is one vendor to use 
> this trick.

If that is really one important point, why not simply adding a :
MODULE_IS_UNDER_GPL_LICENSE("yes|no")
and a
MODULE_IS_UNDER_GPL_LIKE_LICENSE("yes|no")

or use 0 and 1 instead of yes and no, and thus clearly avoid all the
C string mess ?

Regards,
Paul


  parent reply	other threads:[~2007-02-02 15:29 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-28  0:41 [PATCH] Blacklist hsfmodem module Alexey Dobriyan
2006-11-01 11:21 ` Jan Engelhardt
2007-02-01 21:20   ` [PATCH] Ban module license tag string termination trick Jan Engelhardt
2007-02-01 21:28     ` [m-i-t part] " Jan Engelhardt
2007-02-01 21:55     ` [PATCH] " Randy Dunlap
2007-02-01 22:17     ` Jon Masters
2007-02-01 22:30       ` Trent Waddington
2007-02-01 23:34         ` Auke Kok
2007-02-02  8:24           ` David Schwartz
2007-02-02 10:45             ` Helge Hafting
2007-02-03 18:31               ` David Schwartz
2007-02-03 20:47                 ` Jan Engelhardt
2007-02-03 22:21                   ` Alan
2007-02-03 23:32                     ` Jon Masters
2007-02-04  0:05                       ` Alan
2007-02-04  7:56                   ` David Schwartz
2007-02-07 12:18                 ` Helge Hafting
2007-02-07 18:56                   ` David Schwartz
2007-02-12 15:50                     ` Helge Hafting
2007-02-12 16:42                       ` Alan
2007-02-12 22:37                       ` David Schwartz
2007-02-02  0:17       ` Tomas Carnecky
2007-02-02  0:51         ` Trent Waddington
2007-02-02  2:19           ` Valdis.Kletnieks
2007-02-02  3:12           ` Arjan van de Ven
2007-02-02  6:15             ` Jon Masters
2007-02-02 14:53     ` Paul Rolland [this message]
2007-02-02 15:11       ` Jan Engelhardt
2007-02-02 16:53         ` Randy Dunlap
2007-02-02 17:41           ` Jan Engelhardt
2007-02-02 17:49             ` Randy Dunlap
2007-02-02 19:06               ` Jan Engelhardt
2007-02-03  1:12                 ` Randy Dunlap
2007-02-03  1:29                   ` Jan Engelhardt
2007-02-02 18:37         ` Paul Rolland
2007-02-02 19:08           ` Jan Engelhardt
2007-02-04  8:14             ` Paul Rolland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='011601c746d9$dc5453b0$4b00a8c0@donald' \
    --to=rol@as2917.net \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=jengelh@linux01.gwdg.de \
    --cc=jonathan@jonmasters.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='RE: [PATCH] Ban module license tag string termination trick' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).