LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: openat2: Fix testing failure for O_LARGEFILE flag
Date: Wed, 28 Jul 2021 20:32:20 +0800	[thread overview]
Message-ID: <01184d9e-477d-cbe4-c936-62b92e915911@linux.alibaba.com> (raw)
In-Reply-To: <1627475340-128057-1-git-send-email-baolin.wang@linux.alibaba.com>

Hi,

> When running the openat2 test suite on ARM64 platform, we got below failure,
> since the definition of the O_LARGEFILE is different on ARM64. So we can
> set the correct O_LARGEFILE definition on ARM64 to fix this issue.

Sorry, I forgot to copy the failure log:

# openat2 unexpectedly returned # 
3['/lkp/benchmarks/kernel_selftests/tools/testing/selftests/openat2'] 
with 208000 (!= 208000)
not ok 102 openat2 with incompatible flags (O_PATH | O_LARGEFILE) fails 
with -22 (Invalid argument)

> 
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
>   tools/testing/selftests/openat2/openat2_test.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tools/testing/selftests/openat2/openat2_test.c b/tools/testing/selftests/openat2/openat2_test.c
> index d7ec1e7..1bddbe9 100644
> --- a/tools/testing/selftests/openat2/openat2_test.c
> +++ b/tools/testing/selftests/openat2/openat2_test.c
> @@ -22,7 +22,11 @@
>    * XXX: This is wrong on {mips, parisc, powerpc, sparc}.
>    */
>   #undef	O_LARGEFILE
> +#ifdef __aarch64__
> +#define	O_LARGEFILE 0x20000
> +#else
>   #define	O_LARGEFILE 0x8000
> +#endif
>   
>   struct open_how_ext {
>   	struct open_how inner;
> 

  reply	other threads:[~2021-07-28 12:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 12:29 Baolin Wang
2021-07-28 12:32 ` Baolin Wang [this message]
2021-08-23  2:40   ` Baolin Wang
2021-08-23 19:23     ` Shuah Khan
2021-08-24  5:26       ` Baolin Wang
2021-08-24 11:21       ` Aleksa Sarai
2021-08-24 11:36         ` Christian Brauner
2021-08-24 14:33           ` Shuah Khan
2021-08-24 16:50             ` Shuah Khan
2021-08-25  1:49               ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01184d9e-477d-cbe4-c936-62b92e915911@linux.alibaba.com \
    --to=baolin.wang@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --subject='Re: [PATCH] selftests: openat2: Fix testing failure for O_LARGEFILE flag' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).