LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Martin Frey" <frey@scs.ch> To: <becker@scyld.com>, <jgarzik@mandrakesoft.com>, <tjeerd.mulder@fujitsu-siemens.com>, <torvalds@transmeta.com>, <alan@lxorguk.ukuu.org.uk> Cc: <linux-kernel@vger.kernel.org> Subject: Fix for drivers/net/natsemi.c on 64 bit platforms Date: Sun, 7 Oct 2001 14:01:54 -0400 [thread overview] Message-ID: <011d01c14f5a$27c8da50$6a876ace@SCHLEPPDOWN> (raw) Hi, the natsemi.c Ethernet driver cuts the upper bits of the address when accessing the EEPROM. Changing "int ee_addr" to "long ee_addr" in eeprom_read() fixes the problem for me on Alpha. The Bug is in the 2.2.x driver from Donald as well as in the 2.4.x driver. I tested the patch only on 2.4.x however, since it is actually trivial, I guess it will also work for Donalds version. Here is the patch for 2.4.10: --- linux-2.4.10/drivers/net/natsemi.c Tue Aug 14 13:14:12 2001 +++ linux-2.4.10.digitalpw/drivers/net/natsemi.c Fri Oct 5 13:25:59 2001 @@ -633,7 +633,7 @@ { int i; int retval = 0; - int ee_addr = addr + EECtrl; + long ee_addr = addr + EECtrl; int read_cmd = location | EE_ReadCmd; writel(EE_Write0, ee_addr); and here for the driver on the Scyld page: --- natsemi.c.orig Sun Oct 7 13:49:03 2001 +++ natsemi.c Sun Oct 7 13:49:16 2001 @@ -499,7 +499,7 @@ { int i; int retval = 0; - int ee_addr = addr + EECtrl; + long ee_addr = addr + EECtrl; int read_cmd = location | EE_ReadCmd; writel(EE_Write0, ee_addr); Regards, Martin -- Supercomputing Systems AG email: frey@scs.ch Martin Frey web: http://www.scs.ch/~frey/ at Compaq Computer Corporation phone: +1 603 884 4266 ZKO2-3R75, 110 Spit Brook Road, Nashua, NH 03062
next reply other threads:[~2001-10-07 18:02 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2001-10-07 18:01 Martin Frey [this message] 2001-10-07 18:08 ` Fix for drivers/net/natsemi.c on 64 bit platforms Jeff Garzik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='011d01c14f5a$27c8da50$6a876ace@SCHLEPPDOWN' \ --to=frey@scs.ch \ --cc=alan@lxorguk.ukuu.org.uk \ --cc=becker@scyld.com \ --cc=jgarzik@mandrakesoft.com \ --cc=linux-kernel@vger.kernel.org \ --cc=tjeerd.mulder@fujitsu-siemens.com \ --cc=torvalds@transmeta.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).