From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74AB9C4338F for ; Tue, 3 Aug 2021 08:47:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6015360FC2 for ; Tue, 3 Aug 2021 08:47:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234788AbhHCIrq (ORCPT ); Tue, 3 Aug 2021 04:47:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24055 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234654AbhHCIrk (ORCPT ); Tue, 3 Aug 2021 04:47:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627980449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xl6rvqXkmbnAF6T6P/0zNyDHP6RPIaj9Wql4qdg9RG8=; b=Q4+KIbqw1zJocWzJE9QHxsdXzaFvqINSsFj4up5is3Pvz/sinYc3WcEq7B7sct4rO/AnSg usBNyHUIzXkOukA6tWc5ZSk3gZWUbxh+svF+M9C7nHX/zJWtbLRauMzeUpOcBvWcvHzE4M R5E8ndwU5Ab27sWYeObVqzB+5c2hB+w= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-Jbhl6K2aOy29FXGteBCtvw-1; Tue, 03 Aug 2021 04:47:28 -0400 X-MC-Unique: Jbhl6K2aOy29FXGteBCtvw-1 Received: by mail-ej1-f69.google.com with SMTP id nb40-20020a1709071ca8b02905992266c319so2284544ejc.21 for ; Tue, 03 Aug 2021 01:47:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Xl6rvqXkmbnAF6T6P/0zNyDHP6RPIaj9Wql4qdg9RG8=; b=DYk3adCtfPW4GngjQisknwqtq0ODD9L5CA+S8MR30uXn71QSoD+wOYfjAlR4DmnFm+ oG38qfwvxGP1f5zxQaz8XVC93ioiW+Mbvgi2dPE89jjwxgP5X+1nugQShK+A3hmCchL0 HmVCCUxeKg44mDfmbDNWmratH2sLYigu0G9dwVxG+ZELfnSPClnEGn9WwVb8TnotofkB ZWzKwfQwJcvNansDRRSvxF6qb5MhEt71zq/GurQs4/A5YT9ftFv7jSiO2OkXN47a4Yn5 RFQ0LWxCe+AIuKKCWBacXzNWOKzESpv50iJw7T2StN2rKosU3tMR3TJyG1xUIYvbbpXw XKng== X-Gm-Message-State: AOAM5334ZkqzP2gYmJEpvbl4Q4e2jxHGWyZW50RzU/fUh1AbqoGEWSRp IJsA02qpyDSsh9CZd+EG60R0AYkCjr/NbZhwjCQoWUf3eirzTMoyTTJGc/JJVRxcpuMPHqEV5kh uoDfoVADBnFO+YpIK4pRwGUcI X-Received: by 2002:aa7:cb19:: with SMTP id s25mr24561046edt.194.1627980447179; Tue, 03 Aug 2021 01:47:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzu/a0NsuOruUYw+Qh/7giQPJS3e27Uwbx5YV+ZBHGXU82ConO7DZlOMQzEhjHHp5AIyWs0Ow== X-Received: by 2002:aa7:cb19:: with SMTP id s25mr24561034edt.194.1627980447025; Tue, 03 Aug 2021 01:47:27 -0700 (PDT) Received: from [192.168.10.118] ([93.56.169.140]) by smtp.gmail.com with ESMTPSA id j23sm7636816eds.21.2021.08.03.01.47.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Aug 2021 01:47:26 -0700 (PDT) Subject: Re: [PATCH v3 09/12] KVM: x86: hyper-v: Deactivate APICv only when AutoEOI feature is in use To: Maxim Levitsky , kvm@vger.kernel.org Cc: Wanpeng Li , Thomas Gleixner , Joerg Roedel , Borislav Petkov , Sean Christopherson , Jim Mattson , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Suravee Suthikulpanit , Vitaly Kuznetsov , Ingo Molnar , "H. Peter Anvin" References: <20210802183329.2309921-1-mlevitsk@redhat.com> <20210802183329.2309921-10-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: <01449e47-8c9c-7582-d8e9-783c0933f298@redhat.com> Date: Tue, 3 Aug 2021 10:47:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210802183329.2309921-10-mlevitsk@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/21 20:33, Maxim Levitsky wrote: > Maxim: > - always set HV_DEPRECATING_AEOI_RECOMMENDED in kvm_get_hv_cpuid, > since this feature can be used regardless of AVIC I tend to agree here. While AutoEOI does have a minor performance improvement, I suspect that APICv will be available in most cases where Windows guest performance matters to that point. Paolo