LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Diego Guella" <diego.guella@sircomtech.com>
To: "Steve Wise" <swise@opengridcomputing.com>,
	"Roland Dreier" <rdreier@cisco.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<general@lists.openfabrics.org>
Subject: Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.
Date: Wed, 13 Feb 2008 10:18:53 +0100	[thread overview]
Message-ID: <015c01c86e21$75317210$05c8a8c0@DIEGO> (raw)
In-Reply-To: <adafxvxvgz3.fsf@cisco.com>

One question below


----- Original Message ----- 
From: "Roland Dreier" <rdreier@cisco.com>
To: "Steve Wise" <swise@opengridcomputing.com>
Cc: <netdev@vger.kernel.org>; <linux-kernel@vger.kernel.org>; <general@lists.openfabrics.org>
Sent: Wednesday, February 13, 2008 1:26 AM
Subject: Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.


> applied, although:
> 
> > +static void is_loopback_dst(struct iw_cm_id *cm_id)
> > +{
> > + struct net_device *dev;
> > + 
> > + dev = ip_dev_find(&init_net, cm_id->remote_addr.sin_addr.s_addr);
> > + if (!dev)
> > + return 0;

how can a static void function return 0?
%)

> > + dev_put(dev);
> > + return 1;

same here



  parent reply	other threads:[~2008-02-13  9:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 22:09 [PATCH 2.6.25] RDMA/cxgb3: Fail loopback connections Steve Wise
2008-02-13  0:26 ` [ofa-general] " Roland Dreier
2008-02-13  1:41   ` Steve Wise
2008-02-13  9:18   ` Diego Guella [this message]
2008-02-13 15:46     ` [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections Roland Dreier
2008-02-13 15:47       ` Steve Wise
2008-02-13 15:49       ` Roland Dreier
2008-02-13 15:51         ` Steve Wise
2008-02-13 16:03           ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='015c01c86e21$75317210$05c8a8c0@DIEGO' \
    --to=diego.guella@sircomtech.com \
    --cc=general@lists.openfabrics.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdreier@cisco.com \
    --cc=swise@opengridcomputing.com \
    --subject='Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).