LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Guan Xuetao" <gxt@mprc.pku.edu.cn>
To: "'Thomas Gleixner'" <tglx@linutronix.de>,
"'Guan Xuetao'" <guanxuetao@mprc.pku.edu.cn>
Cc: <sfr@canb.auug.org.au>, "'Arnd Bergmann'" <arnd@arndb.de>,
<gregkh@suse.de>, <jbarnes@virtuousgeek.org>,
<dmitry.torokhov@gmail.com>, <dtor@mail.ru>,
<linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-next@vger.kernel.org>
Subject: RE: Request (2nd) for unicore32 architecture codes to merge into linux-next
Date: Fri, 11 Feb 2011 11:18:40 +0800 [thread overview]
Message-ID: <022d01cbc99a$63717e80$2a547b80$@mprc.pku.edu.cn> (raw)
In-Reply-To: <alpine.LFD.2.00.1102062254560.31804@localhost6.localdomain6>
> > arch/unicore32/kernel/time.c | 148 +++++
>
> static struct clock_event_device ckevt_puv3_osmr0 ...
> #ifdef CONFIG_ARCH_FPGA
> .shift = 18, /* correct shift val: 16, but warn_on_slowpath */
> #else
> .shift = 30,
> #endif
>
> ....
> ckevt_puv3_osmr0.mult =
> div_sc(CLOCK_TICK_RATE, NSEC_PER_SEC, ckevt_puv3_osmr0.shift);
>
> Please use the function which calculates the optimizes mult/shift
> values for you depending on the clock frequency.
>
> clockevents_calc_mult_shift() is your friend.
>
> > arch/unicore32/kernel/irq.c | 426 +++++++++++++
>
> Please convert your irq_chips to the new function pointers:
>
> .mask -> .irq_mask
> ...
>
> The new functions replace the "unsigned int irq" argument with
> "struct irq_data *d".
>
> So conversion for your chips is simply
>
> s/unsigned int irq/struct irq_data *d/
>
> and
>
> s/irq/d->irq/ in the implementation.
>
> Then your arch should select: GENERIC_HARDIRQS_NO_DEPRECATED
>
> Otherwise I'm happy with your irq and time related patches.
>
> Thanks,
>
> tglx
Thanks Thomas. I will apply the advice and test it lator.
Guan Xuetao
next prev parent reply other threads:[~2011-02-11 3:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-22 8:33 Guan Xuetao
2011-02-06 22:06 ` Thomas Gleixner
2011-02-11 3:18 ` Guan Xuetao [this message]
2011-01-22 13:52 Xuetao Guan
2011-01-22 22:46 ` Stephen Rothwell
2011-01-24 2:50 ` Guan Xuetao
2011-01-31 22:38 ` Stephen Rothwell
2011-02-01 5:05 ` Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='022d01cbc99a$63717e80$2a547b80$@mprc.pku.edu.cn' \
--to=gxt@mprc.pku.edu.cn \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@mail.ru \
--cc=gregkh@suse.de \
--cc=guanxuetao@mprc.pku.edu.cn \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--subject='RE: Request (2nd) for unicore32 architecture codes to merge into linux-next' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).