LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
	vdavydov.dev@gmail.com, cgroups@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memcontrol: Set the correct memcg swappiness restriction
Date: Tue, 3 Aug 2021 23:45:20 +0800	[thread overview]
Message-ID: <02826fde-43a8-e20d-37f5-55416ba0c773@linux.alibaba.com> (raw)
In-Reply-To: <6e6570d2-44a2-1da1-6c2a-38766786c40c@suse.cz>



On 2021/8/3 23:20, Vlastimil Babka wrote:
> On 7/30/21 8:39 AM, Michal Hocko wrote:
>> On Fri 30-07-21 14:26:35, Baolin Wang wrote:
>>> Since commit c843966c556d ("mm: allow swappiness that prefers reclaiming
>>> anon over the file workingset") has expended the swappiness value to
>>> make swap to be preferred in some systems. We should also change the
>>> memcg swappiness restriction to allow memcg swap-preferred.
>>>
>>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>>
>> Yes, this looks like an omission. It doesn't really make sense to have
>> two different constrains on the value.
>>
>> Acked-by: Michal Hocko <mhocko@suse.com>
> 
> So, also Fixes: c843966c556d ("mm: allow swappiness that prefers reclaiming anon
> over the file workingset")
> ?

Sure. Andrew, do I need resend it with adding fixes tag, or you can help 
to add it? Thanks.

  reply	other threads:[~2021-08-03 15:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30  6:26 Baolin Wang
2021-07-30  6:39 ` Michal Hocko
2021-08-03 15:20   ` Vlastimil Babka
2021-08-03 15:45     ` Baolin Wang [this message]
2021-08-03 20:25       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02826fde-43a8-e20d-37f5-55416ba0c773@linux.alibaba.com \
    --to=baolin.wang@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=vbabka@suse.cz \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH] mm: memcontrol: Set the correct memcg swappiness restriction' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).