LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Stuart MacDonald" <stuartm@connecttech.com>
To: "'Russell King'" <rmk+lkml@arm.linux.org.uk>,
	"'Rob Prowel'" <prowel@kuchera.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: questions about 8250 uart support for adhoc boards
Date: Tue, 27 Feb 2007 14:06:04 -0500	[thread overview]
Message-ID: <028501c75aa2$54ae9d80$294b82ce@stuartm> (raw)
In-Reply-To: <20070227173844.GA10380@flint.arm.linux.org.uk>

From: Russell King [mailto:rmk@arm.linux.org.uk]
> After experimenting here, it turns out the reason is you're trying to
> configure a port with a zero base baud.  Unfortunately, it starts off
> as zero.

That explains why adding the fourport module fixed Rob's issue, as the
fourport code sets a uartclk value for its ports.

> However, when you try to change a port without specifying the 
> base baud,
> it is possible for the port to become "usable" and unless we enforce
> the "must not have zero base baud" rule we have the 
> possibility to oops
> the kernel via a divide by zero.
> 
> So, the answer is to specify the base baud when using setserial to
> configure new ports.

Would it be more intuitive to give ports the default uartclk of
1843200 at init time? That would avoid this issue, but would make the
baud rates come out wrong on hardware with a non-standard clock, if a
base baud wasn't specified.


From: Rob Prowel [mailto:prowel@kuchera.com] 
> your website address didn't work when I tried it...

The website may have been down on the weekend for maintenance. Please
try again.

..Stu

-- 
We make multiport serial products.
http://www.connecttech.com/
(800) 426-8979


  reply	other threads:[~2007-02-27 19:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-23 17:05 questions about 8250 uart support for adhoc boards Rob Prowel
2007-02-23 20:21 ` Russell King
2007-02-23 20:48   ` Rob Prowel
2007-02-24 20:34     ` Stuart MacDonald
2007-02-26 17:02       ` Rob Prowel
2007-02-26 18:05         ` Russell King
2007-02-27 14:24           ` Rob Prowel
2007-02-27 17:38             ` Russell King
2007-02-27 19:06               ` Stuart MacDonald [this message]
2007-02-27 20:40                 ` Rob Prowel
2007-03-08 15:16                   ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='028501c75aa2$54ae9d80$294b82ce@stuartm' \
    --to=stuartm@connecttech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prowel@kuchera.com \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).