LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
USB development list <linux-usb-devel@lists.sourceforge.net>,
Pete Zaitcev <zaitcev@redhat.com>, Greg KH <gregkh@suse.de>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [linux-usb-devel] 2.6.20 kernel hang with USB drive and vfat doing ftruncate
Date: Thu, 22 Feb 2007 12:20:06 -0600 [thread overview]
Message-ID: <0305C117-1099-49EA-B0F3-C0E31E18A19A@kernel.crashing.org> (raw)
In-Reply-To: <F2C532BC-C83A-4DD5-BACE-49F8CC11236C@kernel.crashing.org>
>>>> Not that it'll help much: the VM calls throttle_vm_writeout()
>>>> for GFP_NOIO
>>>> and GFP_NOFS allocations, which is a bug. Because if the caller
>>>> holds
>>>> locks which prevent filesystem or IO progress, we deadlock.
>>>>
>>>> I'll fix the VM if someone else fixes USB ;)
>>>
>>> What else needs to be fixed?
>>
>> Would be nice if someone can confirm that this fixes it:
>
> Doesn't seem to help my problem in a quick test, will get more data
> in the morning.
\x7f
Well, I didn't realize the patch you sent via mm-commits and the one
here are actually different. I noticed that mm-commits one has:
+ if ((gfp_mask & (__GFP_FS|__GFP_IO)) != __GFP_FS|__GFP_IO) {
vs
+ if ((gfp_mask & (__GFP_FS|__GFP_IO)) != (__GFP_FS|__GFP_IO)) {
The second seems to make more sense. I tested with the first last
night which didn't help.
With the proper patch in place things look good. Is this a candidate
for 2.6.20-stable?
- k
next prev parent reply other threads:[~2007-02-22 18:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 19:54 Kumar Gala
2007-02-18 16:10 ` OGAWA Hirofumi
2007-02-19 21:58 ` Kumar Gala
2007-02-19 22:19 ` OGAWA Hirofumi
2007-02-19 22:27 ` Kumar Gala
2007-02-20 17:20 ` OGAWA Hirofumi
2007-02-19 22:06 ` Kumar Gala
2007-02-21 20:18 ` OGAWA Hirofumi
2007-02-21 20:57 ` Andrew Morton
2007-02-21 21:22 ` [linux-usb-devel] " Alan Stern
2007-02-21 21:31 ` Andrew Morton
2007-02-21 21:50 ` Alan Stern
2007-02-21 22:54 ` Andrew Morton
2007-02-22 7:40 ` Kumar Gala
2007-02-22 18:20 ` Kumar Gala [this message]
2007-02-22 21:57 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0305C117-1099-49EA-B0F3-C0E31E18A19A@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=stern@rowland.harvard.edu \
--cc=zaitcev@redhat.com \
--subject='Re: [linux-usb-devel] 2.6.20 kernel hang with USB drive and vfat doing ftruncate' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).