LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: [PATCH 14/20] media: adv7511: drop unused functions
Date: Wed, 24 Nov 2021 20:13:17 +0100	[thread overview]
Message-ID: <031cdb0042f8239a6746831f5c8f89cf4aef6107.1637781097.git.mchehab+huawei@kernel.org> (raw)
In-Reply-To: <cover.1637781097.git.mchehab+huawei@kernel.org>

Those are aliases for another function and not used at the
current implementation. So, just drop it.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH 00/20] at: https://lore.kernel.org/all/cover.1637781097.git.mchehab+huawei@kernel.org/

 drivers/media/i2c/adv7511-v4l2.c | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/drivers/media/i2c/adv7511-v4l2.c b/drivers/media/i2c/adv7511-v4l2.c
index 41f4e749a859..8e13cae40ec5 100644
--- a/drivers/media/i2c/adv7511-v4l2.c
+++ b/drivers/media/i2c/adv7511-v4l2.c
@@ -270,28 +270,6 @@ static int adv7511_pktmem_rd(struct v4l2_subdev *sd, u8 reg)
 	return adv_smbus_read_byte_data(state->i2c_pktmem, reg);
 }
 
-static int adv7511_pktmem_wr(struct v4l2_subdev *sd, u8 reg, u8 val)
-{
-	struct adv7511_state *state = get_adv7511_state(sd);
-	int ret;
-	int i;
-
-	for (i = 0; i < 3; i++) {
-		ret = i2c_smbus_write_byte_data(state->i2c_pktmem, reg, val);
-		if (ret == 0)
-			return 0;
-	}
-	v4l2_err(sd, "%s: i2c write error\n", __func__);
-	return ret;
-}
-
-/* To set specific bits in the register, a clear-mask is given (to be AND-ed),
-   and then the value-mask (to be OR-ed). */
-static inline void adv7511_pktmem_wr_and_or(struct v4l2_subdev *sd, u8 reg, u8 clr_mask, u8 val_mask)
-{
-	adv7511_pktmem_wr(sd, reg, (adv7511_pktmem_rd(sd, reg) & clr_mask) | val_mask);
-}
-
 static inline bool adv7511_have_hotplug(struct v4l2_subdev *sd)
 {
 	return adv7511_rd(sd, 0x42) & MASK_ADV7511_HPD_DETECT;
-- 
2.33.1


  parent reply	other threads:[~2021-11-24 19:14 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 19:13 [PATCH 00/20] Solve the remaining issues with clang and W=1 on media Mauro Carvalho Chehab
2021-11-24 19:13 ` [PATCH 01/20] media: adv7842: get rid of two unused functions Mauro Carvalho Chehab
2021-11-26 18:54   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 02/20] media: saa7134-go7007: get rid of to_state() function Mauro Carvalho Chehab
2021-11-26 18:55   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 03/20] media: davinci: get rid of an unused function Mauro Carvalho Chehab
2021-11-26 18:56   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 04/20] media: drxd: drop offset var from DownloadMicrocode() Mauro Carvalho Chehab
2021-11-26 18:57   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 05/20] media: drxk: drop operation_mode from set_dvbt() Mauro Carvalho Chehab
2021-11-26 19:02   ` Nathan Chancellor
2021-11-29  8:33     ` [PATCH v2 " Mauro Carvalho Chehab
2021-11-24 19:13 ` [PATCH 06/20] media: m88ds3103: drop reg11 calculus from m88ds3103b_select_mclk() Mauro Carvalho Chehab
2021-11-26 19:40   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 07/20] media: si21xx: report eventual errors at set_frontend Mauro Carvalho Chehab
2021-11-26 19:45   ` Nathan Chancellor
2021-11-29  8:40     ` Mauro Carvalho Chehab
2021-11-24 19:13 ` [PATCH 08/20] media: solo6x10: add _maybe_unused to currently unused functions Mauro Carvalho Chehab
2021-11-25 21:18   ` Ismael Luceno
2021-11-26 19:58   ` Nathan Chancellor
2021-11-29  8:44     ` Mauro Carvalho Chehab
2021-11-24 19:13 ` [PATCH 09/20] media: si470x: fix printk warnings with clang Mauro Carvalho Chehab
2021-11-26 20:13   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 10/20] media: radio-si476x: drop a container_of() abstraction macro Mauro Carvalho Chehab
2021-11-26 20:14   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 11/20] media: lmedm04: don't ignore errors when setting a filter Mauro Carvalho Chehab
2021-11-26 20:16   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 12/20] media: au0828-i2c: drop a duplicated function Mauro Carvalho Chehab
2021-11-26 20:22   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 13/20] media: adv7604 add _maybe_unused to currently unused functions Mauro Carvalho Chehab
2021-11-24 19:13 ` Mauro Carvalho Chehab [this message]
2021-11-26 20:27   ` [PATCH 14/20] media: adv7511: drop " Nathan Chancellor
2021-11-24 19:13 ` [PATCH 15/20] media: imx290: mark read reg function as __maybe_unused Mauro Carvalho Chehab
2021-11-24 19:13 ` [PATCH 16/20] media: davinci: vpbe_osd: " Mauro Carvalho Chehab
2021-11-24 19:13 ` [PATCH 17/20] media: qcom: camss: " Mauro Carvalho Chehab
2021-11-25 10:58   ` Robert Foss
2021-11-24 19:13 ` [PATCH 18/20] media: mtk-mdp: address a clang warning Mauro Carvalho Chehab
2021-11-24 19:21   ` Arnd Bergmann
2021-11-24 19:13 ` [PATCH 19/20] media: cobalt: drop an unused variable Mauro Carvalho Chehab
2021-11-26 20:29   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 20/20] media: mxl5005s: drop some dead code Mauro Carvalho Chehab
2021-11-26 20:30   ` Nathan Chancellor
2021-11-24 19:23 ` [PATCH 00/20] Solve the remaining issues with clang and W=1 on media Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=031cdb0042f8239a6746831f5c8f89cf4aef6107.1637781097.git.mchehab+huawei@kernel.org \
    --to=mchehab+huawei@kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mauro.chehab@huawei.com \
    --cc=mchehab@kernel.org \
    --subject='Re: [PATCH 14/20] media: adv7511: drop unused functions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).