LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
	"'Rob Herring'" <robh+dt@kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: "'Chanwoo Choi'" <cw00.choi@samsung.com>,
	"'Pankaj Dubey'" <pankaj.dubey@samsung.com>,
	"'Sam Protsenko'" <semen.protsenko@linaro.org>,
	"'Marc Zyngier'" <maz@kernel.org>
Subject: RE: [PATCH] arm64: dts: exynos: correct GIC CPU interfaces address range on Exynos7
Date: Thu, 5 Aug 2021 14:56:14 +0530	[thread overview]
Message-ID: <03d701d789db$f275d290$d76177b0$@samsung.com> (raw)
In-Reply-To: <b0d6ff2a-24af-96c1-62a1-8b920c63e05a@canonical.com>

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Sent: 05 August 2021 13:07
> To: Rob Herring <robh+dt@kernel.org>; devicetree@vger.kernel.org; linux-
> arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Alim Akhtar <alim.akhtar@samsung.com>; Chanwoo Choi
> <cw00.choi@samsung.com>; Pankaj Dubey <pankaj.dubey@samsung.com>;
> Sam Protsenko <semen.protsenko@linaro.org>; Marc Zyngier
> <maz@kernel.org>
> Subject: Re: [PATCH] arm64: dts: exynos: correct GIC CPU interfaces address
> range on Exynos7
> 
> On 05/08/2021 09:21, Krzysztof Kozlowski wrote:
> > The GIC-400 CPU interfaces address range is defined as 0x2000-0x3FFF
> > (by ARM).
> >
> 
Looking at DDI0471B_gic400_r0p1_trm.pdf, CPU interface range is 0x0000 ~ 0x10000

> I underestimated the issue - this is actually bug as there is a GICC_DIR
> register at offset 0x1000. Therefore:
> 
Looking at the exynos7 and exynos5433 UMs looks like GICC_DIR is at offset 0x2100 (from 0x1100_0000 GIC base)
It is possible for you to cross check once?

> Fixes: b9024cbc937d ("arm64: dts: Add initial device tree support for
> exynos7")
> 
> > Reported-by: Sam Protsenko <semen.protsenko@linaro.org>
> > Reported-by: Marc Zyngier <maz@kernel.org>
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > ---
> >  arch/arm64/boot/dts/exynos/exynos7.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> > b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> > index 8b06397ba6e7..c73a597ca66e 100644
> > --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> > +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> > @@ -137,7 +137,7 @@ gic: interrupt-controller@11001000 {
> >  			#address-cells = <0>;
> >  			interrupt-controller;
> >  			reg =	<0x11001000 0x1000>,
> > -				<0x11002000 0x1000>,
> > +				<0x11002000 0x2000>,
> >  				<0x11004000 0x2000>,
> >  				<0x11006000 0x2000>;
> >  		};
> >
> 
> 
> Best regards,
> Krzysztof


  reply	other threads:[~2021-08-05  9:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05  7:21 Krzysztof Kozlowski
2021-08-05  7:36 ` Krzysztof Kozlowski
2021-08-05  9:26   ` Alim Akhtar [this message]
2021-08-05  9:43     ` Krzysztof Kozlowski
2021-08-05  9:44       ` Krzysztof Kozlowski
2021-08-05  9:54         ` Alim Akhtar
     [not found]     ` <87tuk4b47s.wl-maz@kernel.org>
2021-08-05 10:51       ` Alim Akhtar
2021-08-05 11:26 ` Sam Protsenko
2021-08-09 10:38 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='03d701d789db$f275d290$d76177b0$@samsung.com' \
    --to=alim.akhtar@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=pankaj.dubey@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --subject='RE: [PATCH] arm64: dts: exynos: correct GIC CPU interfaces address range on Exynos7' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).