LKML Archive on
help / color / mirror / Atom feed
From: Alexey Khoroshilov <>
To: Boris Brezillon <>
Cc: Joachim Eastwood <>,
	Marek Vasut <>,
	David Woodhouse <>,
	Brian Norris <>,,,
	Richard Weinberger <>,, Julia Lawall <>,,
Subject: Re: [PATCH] mtd: nxp-spifi: decrement flash_np refcnt on error paths
Date: Wed, 9 May 2018 17:35:41 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20180509114250.120eb299@bbrezillon>

On 09.05.2018 12:42, Boris Brezillon wrote:
> On Tue,  8 May 2018 23:47:36 +0300
> Alexey Khoroshilov <> wrote:
>> nxp_spifi_probe() increments refcnt of SPI flash device node by
>> of_get_next_available_child() and then it passes the node
>> to mtd device in nxp_spifi_setup_flash().
>> But if a failure happens before mtd_device_register() succeed,
>> the refcnt is left undecremented.
> Why not doing that in the error path of the probe function? Also, you
> probably want to call of_node_put() in the ->remove() function.

You are right.

I believed that after successful mtd_device_register()
the node is managed by mtd device. I missed that it calls of_node_get()
in add_mtd_device() by itself.

I will prepare v2.
But I guess there is no need to have of_node_put() in ->remove(), since
probe() finishes its own usage of flash_np, while mtd_device incremented
refcnt by itself and will decrement it in ->remove() in
mtd_device_unregister(&spifi->nor.mtd). So, I would propose
of_node_put() on both successful and error path.

Thank you,

  reply	other threads:[~2018-05-09 14:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 20:47 [PATCH] mtd: nxp-spifi: decrement flash_np refcnt on error paths Alexey Khoroshilov
2018-05-09  9:42 ` Boris Brezillon
2018-05-09 14:35   ` Alexey Khoroshilov [this message]
2018-05-09 14:39     ` Boris Brezillon
2018-05-09 14:56       ` [PATCH v2] mtd: nxp-spifi: release flash_np in nxp_spifi_probe() Alexey Khoroshilov
2018-05-09 15:03         ` Boris Brezillon
2018-05-09 15:11           ` [PATCH v3] " Alexey Khoroshilov
2018-07-07  6:58             ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).