LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Patro, Sumant" <Sumant.Patro@lsi.com>
To: "James Bottomley" <James.Bottomley@SteelEye.com>,
	"Andrew Morton" <akpm@linux-foundation.org>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"Kolli, Neela" <Neela.Kolli@lsi.com>,
	"Yang, Bo" <Bo.Yang@lsi.com>
Subject: RE: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctlprocessing
Date: Wed, 7 Feb 2007 19:54:38 -0700	[thread overview]
Message-ID: <0631C836DBF79F42B5A60C8C8D4E82298ED5D6@NAMAIL2.ad.lsil.com> (raw)

Thanks.
I will resubmit the patch.

Regards,
Sumant 

-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@SteelEye.com] 
Sent: Wednesday, February 07, 2007 2:02 PM
To: Andrew Morton
Cc: Patro, Sumant; linux-scsi@vger.kernel.org;
linux-kernel@vger.kernel.org; Kolli, Neela; Yang, Bo; Patro, Sumant
Subject: Re: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for
ioctlprocessing

On Wed, 2007-02-07 at 13:30 -0800, Andrew Morton wrote:
> I suspect all this horror is due to stupidity in the DMA API.
> 
> pci_alloc_consistent() just goes and assumes GFP_ATOMIC, whereas the 
> caller (megasas_mgmt_fw_ioctl) would have been perfectly happy to use 
> GFP_KERNEL.
> 
> I bet this fixes it

It does, but the DMA API was expanded to cope with this exact case, so
use dma_alloc_coherent() directly in the megaraid code instead.  The dev
is just &pci_dev->dev.

James



                 reply	other threads:[~2007-02-08  2:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0631C836DBF79F42B5A60C8C8D4E82298ED5D6@NAMAIL2.ad.lsil.com \
    --to=sumant.patro@lsi.com \
    --cc=Bo.Yang@lsi.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=Neela.Kolli@lsi.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --subject='RE: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctlprocessing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).