LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* RE: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctlprocessing
@ 2007-02-08  2:54 Patro, Sumant
  0 siblings, 0 replies; only message in thread
From: Patro, Sumant @ 2007-02-08  2:54 UTC (permalink / raw)
  To: James Bottomley, Andrew Morton
  Cc: linux-scsi, linux-kernel, Kolli, Neela, Yang, Bo

Thanks.
I will resubmit the patch.

Regards,
Sumant 

-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@SteelEye.com] 
Sent: Wednesday, February 07, 2007 2:02 PM
To: Andrew Morton
Cc: Patro, Sumant; linux-scsi@vger.kernel.org;
linux-kernel@vger.kernel.org; Kolli, Neela; Yang, Bo; Patro, Sumant
Subject: Re: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for
ioctlprocessing

On Wed, 2007-02-07 at 13:30 -0800, Andrew Morton wrote:
> I suspect all this horror is due to stupidity in the DMA API.
> 
> pci_alloc_consistent() just goes and assumes GFP_ATOMIC, whereas the 
> caller (megasas_mgmt_fw_ioctl) would have been perfectly happy to use 
> GFP_KERNEL.
> 
> I bet this fixes it

It does, but the DMA API was expanded to cope with this exact case, so
use dma_alloc_coherent() directly in the megaraid code instead.  The dev
is just &pci_dev->dev.

James



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-02-08  2:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-08  2:54 [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctlprocessing Patro, Sumant

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).