LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Patro, Sumant" <Sumant.Patro@lsi.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: <James.Bottomley@SteelEye.com>, <linux-scsi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	"Kolli, Neela" <Neela.Kolli@lsi.com>,
	"Yang, Bo" <Bo.Yang@lsi.com>
Subject: RE: [PATCH 1/5] scsi: megaraid_sas - stop cmd processing if hw_crit_error is set
Date: Wed, 7 Feb 2007 19:59:36 -0700	[thread overview]
Message-ID: <0631C836DBF79F42B5A60C8C8D4E82298ED5D7@NAMAIL2.ad.lsil.com> (raw)

I will correct the formatting and will resubmit.

Regards,
Sumant 

-----Original Message-----
From: Andrew Morton [mailto:akpm@linux-foundation.org] 
Sent: Wednesday, February 07, 2007 1:18 PM
To: Patro, Sumant
Cc: James.Bottomley@SteelEye.com; linux-scsi@vger.kernel.org;
linux-kernel@vger.kernel.org; Kolli, Neela; Yang, Bo; Patro, Sumant
Subject: Re: [PATCH 1/5] scsi: megaraid_sas - stop cmd processing if
hw_crit_error is set

On Tue, 06 Feb 2007 13:49:24 -0800
Sumant Patro <sumantp@lsil.com> wrote:

> +	/* Don't process if we have already declared adapter dead */
> +	if(instance->hw_crit_error)

Preferred kernel coding style is "if (".

> [p1-crit_err.patch  text/x-patch (1.3KB)]

argh.  Please don't send two copies of the patch in the email.  Because
the result applies happily with `patch --dry-run' and then creates a
great mess when you try to apply the patch for real.


             reply	other threads:[~2007-02-08  2:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08  2:59 Patro, Sumant [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-02-06 21:49 Sumant Patro
2007-02-07 21:17 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0631C836DBF79F42B5A60C8C8D4E82298ED5D7@NAMAIL2.ad.lsil.com \
    --to=sumant.patro@lsi.com \
    --cc=Bo.Yang@lsi.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=Neela.Kolli@lsi.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --subject='RE: [PATCH 1/5] scsi: megaraid_sas - stop cmd processing if hw_crit_error is set' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).