From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752636AbbCaG4H (ORCPT ); Tue, 31 Mar 2015 02:56:07 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:37145 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbbCaGzg (ORCPT ); Tue, 31 Mar 2015 02:55:36 -0400 X-AuditID: cbfee691-f79b86d000004a5a-63-551a44e6ca5e From: Kukjin Kim To: "'Javier Martinez Canillas'" , "'Chanwoo Choi'" Cc: "'Krzysztof Kozlowski'" , "'Kukjin Kim'" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, "'Linux Kernel'" , "'Kyungmin Park'" , "'Marek Szyprowski'" , "'Markus Reichl'" References: <1427728889-29158-1-git-send-email-k.kozlowski@samsung.com> <551A1D27.6000301@samsung.com> In-reply-to: Subject: RE: [PATCH] ARM: dts: Use define for s3c-rtc clock id Date: Tue, 31 Mar 2015 15:55:32 +0900 Message-id: <064c01d06b7f$aed30cf0$0c7926d0$@kernel.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQGSnm0/HHps0bOKqkTAw0a4JImYEwGH+i8eAhuk7VGdlKVbsA== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsWyRsSkQ/eZi1SoQdNtZovrX56zWsw/co7V 4trvGWwWr18YWvQ/fs1scbbpDbvFpsfXWC0u75rDZjHj/D4mi5dHfjBarD1yl92B2+Pv7FZm j1t36j02repk89i8pN6jb8sqRo/Pm+QC2KK4bFJSczLLUov07RK4Mla8PMFc8IqnYv+cS6wN jMu5uhg5OSQETCS+rj/AAmGLSVy4t56ti5GLQ0hgKaNEy9aFTDBF8/82gtlCAtMZJeZOFoEo es8o8eP4R/YuRg4ONgFlicYmfZAaYQEtiYVbmsCGigjEScybcgZsKLPALyaJ7gmXmSCa1zNK vD99AWwqp0CwxPENjewQ3XYSU7tmg9ksAqoSj/bsBbN5BSwkVt3eygJhC0r8mHyPBWQxs4C6 xJQpuSBhZgF5ic1r3jJDHK0gsePsa0aII5wkPj3byQhRIyKx78U7RpAbJARmckgs6tvAArFL QOLb5ENgMyUEZCU2HYCaIylxcMUNlgmMkrOQbJ6FsHkWks2zkGxYwMiyilE0tSC5oDgpvchU rzgxt7g0L10vOT93EyMwAZz+92ziDsb7B6wPMQpwMCrx8FbckQwVYk0sK67MPcRoCnTQRGYp 0eR8YJrJK4k3NDYzsjA1MTU2Mrc0UxLn1ZH+GSwkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qB Me83Q8Izl6P3J/3dvMAx2ybGbHOozdpZfr3nazQSru25oKz1ViRQemG7qcPbj+GyipctlCoc 3/2dOS9vx8PT0Y9/6X+Mfl5Rtl66oq2Ks8VS98E5gffZbqe+bepStbodFnzdbbXX0/RrgmsU fSVnvYv+nvvuaMOa6RPSz4S5Pgmc0qtj9GaLnxJLcUaioRZzUXEiALaCWqL7AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEKsWRmVeSWpSXmKPExsVy+t9jQd2nLlKhBk+vWltc//Kc1WL+kXOs Ftd+z2CzeP3C0KL/8Wtmi7NNb9gtNj2+xmpxedccNosZ5/cxWbw88oPRYu2Ru+wO3B5/Z7cy e9y6U++xaVUnm8fmJfUefVtWMXp83iQXwBbVwGiTkZqYklqkkJqXnJ+SmZduq+QdHO8cb2pm YKhraGlhrqSQl5ibaqvk4hOg65aZA3SdkkJZYk4pUCggsbhYSd8O04TQEDddC5jGCF3fkCC4 HiMDNJCwjjFjxcsTzAWveCr2z7nE2sC4nKuLkZNDQsBEYv7fRiYIW0ziwr31bCC2kMB0Rom5 k0W6GLmA7PeMEj+Of2TvYuTgYBNQlmhs0gepERbQkli4pYkFxBYRiJOYN+UMG0g9s8AvJonu CZeZIJrXM0q8P30BbAOnQLDE8Q2N7BDddhJTu2aD2SwCqhKP9uwFs3kFLCRW3d7KAmELSvyY fI8FZDGzgLrElCm5IGFmAXmJzWveMkMcrSCx4+xrRogjnCQ+PdvJCFEjIrHvxTvGCYzCs5BM moUwaRaSSbOQdCxgZFnFKJpakFxQnJSea6hXnJhbXJqXrpecn7uJEZxenkntYFzZYHGIUYCD UYmH98I9yVAh1sSy4srcQ4wSHMxKIrx7PgKFeFMSK6tSi/Lji0pzUosPMZoC/TmRWUo0OR+Y +vJK4g2NTcyMLI3MLIxMzM2VxHmV7NtChATSE0tSs1NTC1KLYPqYODilGhhzT2aE+ypEH0jO 6Xcsa4vdL3fzd4Y561LPg9EbErplEq9Mc/+fs0aX//1Cvo1OYjJ+By5t7P746OXS8GST//UN y5f9P6YS4bH2Y7YT29b/rIsqtXd2xKQvKH4i46L6cOZ2I6+fUReyJpUl19fPkjA9qGtxQ/oy r+LbE5JiZ7U3i74Q0y26p6nEUpyRaKjFXFScCABlK2uRRQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Javier Martinez Canillas wrote: > > On Tue, Mar 31, 2015 at 6:05 AM, Chanwoo Choi wrote: > > Hi, > > > > On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote: > >> Use a define instead of raw number as a ID for "rtc_src" clock. > >> > >> Signed-off-by: Krzysztof Kozlowski > >> > >> --- > >> > >> Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from: > >> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg43136.html > >> --- > >> arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts > >> index 3905824cac58..d2cbc95364de 100644 > >> --- a/arch/arm/boot/dts/exynos3250-rinato.dts > >> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts > >> @@ -16,6 +16,7 @@ > >> #include "exynos3250.dtsi" > >> #include > >> #include > >> +#include > >> > >> / { > >> model = "Samsung Rinato board"; > >> @@ -605,7 +606,7 @@ > >> }; > >> > >> &rtc { > >> - clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>; > >> + clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>; > >> clock-names = "rtc", "rtc_src"; > >> status = "okay"; > >> }; > >> > > > > Looks good to me. > > > > Reviewed-by: Chanwoo Choi > > > > Reviewed-by: Javier Martinez Canillas > Thanks for you guys' review. Applied. - Kukjin