LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ACPI: APD: Add AMD misc clock handler support
@ 2018-04-30  7:10 Akshu Agrawal
  2018-04-30  8:53 ` kbuild test robot
  0 siblings, 1 reply; 4+ messages in thread
From: Akshu Agrawal @ 2018-04-30  7:10 UTC (permalink / raw)
  Cc: djkurtz, akshu.agrawal, Alexander.Deucher, Rafael J. Wysocki,
	Len Brown, open list:ACPI, open list

AMD SoC exposes clock for general purpose use. The clock registration
is done in clk-st driver. The MMIO mapping are passed on to the
clock driver for accessing the registers.
The misc clock handler will create MMIO mappings to access the
clock registers and enable the clock driver to expose the clock
for use of drivers which will connect to it.

Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
---
 drivers/acpi/acpi_apd.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index d553b00..6328031 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -11,6 +11,7 @@
  */
 
 #include <linux/clk-provider.h>
+#include <linux/platform_data/clk-st.h>
 #include <linux/platform_device.h>
 #include <linux/pm_domain.h>
 #include <linux/clkdev.h>
@@ -72,6 +73,54 @@ static int acpi_apd_setup(struct apd_private_data *pdata)
 }
 
 #ifdef CONFIG_X86_AMD_PLATFORM_DEVICE
+
+static int misc_check_res(struct acpi_resource *ares, void *data)
+{
+	struct resource res;
+
+	return !acpi_dev_resource_memory(ares, &res);
+}
+
+static int st_misc_setup(struct apd_private_data *pdata)
+{
+	struct acpi_device *adev = pdata->adev;
+	struct platform_device *clkdev;
+	struct st_clk_data *clk_data;
+	struct resource_entry *rentry;
+	struct list_head resource_list;
+	int ret;
+
+	clk_data = devm_kzalloc(&adev->dev, sizeof(*clk_data), GFP_KERNEL);
+	if (!clk_data)
+		return -ENOMEM;
+
+	INIT_LIST_HEAD(&resource_list);
+	ret = acpi_dev_get_resources(adev, &resource_list, misc_check_res,
+				     NULL);
+	if (ret < 0) {
+		devm_kfree(&adev->dev, clk_data);
+		return -ENOMEM;
+	}
+
+	list_for_each_entry(rentry, &resource_list, node) {
+		clk_data->base = ioremap(rentry->res->start,
+					 resource_size(rentry->res));
+		break;
+	}
+
+	acpi_dev_free_resource_list(&resource_list);
+
+	clkdev = platform_device_register_data(&adev->dev, "clk-st",
+					       PLATFORM_DEVID_NONE, clk_data,
+					       sizeof(*clk_data));
+	if (IS_ERR(clkdev)) {
+		kfree(clk_data);
+		return PTR_ERR(clkdev);
+	}
+
+	return 0;
+}
+
 static const struct apd_device_desc cz_i2c_desc = {
 	.setup = acpi_apd_setup,
 	.fixed_clk_rate = 133000000,
@@ -94,6 +143,10 @@ static int acpi_apd_setup(struct apd_private_data *pdata)
 	.fixed_clk_rate = 48000000,
 	.properties = uart_properties,
 };
+
+static const struct apd_device_desc st_misc_desc = {
+	.setup = st_misc_setup,
+};
 #endif
 
 #ifdef CONFIG_ARM64
@@ -179,6 +232,7 @@ static int acpi_apd_create_device(struct acpi_device *adev,
 	{ "AMD0020", APD_ADDR(cz_uart_desc) },
 	{ "AMDI0020", APD_ADDR(cz_uart_desc) },
 	{ "AMD0030", },
+	{ "AMD0040", APD_ADDR(st_misc_desc)},
 #endif
 #ifdef CONFIG_ARM64
 	{ "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
-- 
1.9.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ACPI: APD: Add AMD misc clock handler support
  2018-04-30  7:10 [PATCH] ACPI: APD: Add AMD misc clock handler support Akshu Agrawal
@ 2018-04-30  8:53 ` kbuild test robot
  2018-04-30  9:40   ` Agrawal, Akshu
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2018-04-30  8:53 UTC (permalink / raw)
  To: Akshu Agrawal
  Cc: kbuild-all, djkurtz, akshu.agrawal, Alexander.Deucher,
	Rafael J. Wysocki, Len Brown, open list:ACPI, open list

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

Hi Akshu,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pm/linux-next]
[also build test ERROR on v4.17-rc3 next-20180426]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Akshu-Agrawal/ACPI-APD-Add-AMD-misc-clock-handler-support/20180430-152810
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-acpi-redef (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> drivers//acpi/acpi_apd.c:14:10: fatal error: linux/platform_data/clk-st.h: No such file or directory
    #include <linux/platform_data/clk-st.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   compilation terminated.

vim +14 drivers//acpi/acpi_apd.c

  > 14	#include <linux/platform_data/clk-st.h>
    15	#include <linux/platform_device.h>
    16	#include <linux/pm_domain.h>
    17	#include <linux/clkdev.h>
    18	#include <linux/acpi.h>
    19	#include <linux/err.h>
    20	#include <linux/pm.h>
    21	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30366 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ACPI: APD: Add AMD misc clock handler support
  2018-04-30  8:53 ` kbuild test robot
@ 2018-04-30  9:40   ` Agrawal, Akshu
  2018-05-01  9:33     ` Rafael J. Wysocki
  0 siblings, 1 reply; 4+ messages in thread
From: Agrawal, Akshu @ 2018-04-30  9:40 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all, djkurtz, Alexander.Deucher, Rafael J. Wysocki,
	Len Brown, open list:ACPI, open list



On 4/30/2018 2:23 PM, kbuild test robot wrote:
> Hi Akshu,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on pm/linux-next]
> [also build test ERROR on v4.17-rc3 next-20180426]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Akshu-Agrawal/ACPI-APD-Add-AMD-misc-clock-handler-support/20180430-152810
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
> config: x86_64-acpi-redef (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
>          # save the attached .config to linux build tree
>          make ARCH=x86_64
> 
> All errors (new ones prefixed by >>):
> 
>>> drivers//acpi/acpi_apd.c:14:10: fatal error: linux/platform_data/clk-st.h: No such file or directory
>      #include <linux/platform_data/clk-st.h>
>               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     compilation terminated.
> 

This patch is dependent on https://patchwork.kernel.org/patch/10370955/
The above patch adds the required include file.

Thanks,
Akshu
> vim +14 drivers//acpi/acpi_apd.c
> 
>    > 14	#include <linux/platform_data/clk-st.h>
>      15	#include <linux/platform_device.h>
>      16	#include <linux/pm_domain.h>
>      17	#include <linux/clkdev.h>
>      18	#include <linux/acpi.h>
>      19	#include <linux/err.h>
>      20	#include <linux/pm.h>
>      21	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ACPI: APD: Add AMD misc clock handler support
  2018-04-30  9:40   ` Agrawal, Akshu
@ 2018-05-01  9:33     ` Rafael J. Wysocki
  0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2018-05-01  9:33 UTC (permalink / raw)
  To: Agrawal, Akshu
  Cc: kbuild test robot, kbuild-all, djkurtz, Alexander.Deucher,
	Len Brown, open list:ACPI, open list

On Monday, April 30, 2018 11:40:08 AM CEST Agrawal, Akshu wrote:
> 
> On 4/30/2018 2:23 PM, kbuild test robot wrote:
> > Hi Akshu,
> > 
> > Thank you for the patch! Yet something to improve:
> > 
> > [auto build test ERROR on pm/linux-next]
> > [also build test ERROR on v4.17-rc3 next-20180426]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Akshu-Agrawal/ACPI-APD-Add-AMD-misc-clock-handler-support/20180430-152810
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
> > config: x86_64-acpi-redef (attached as .config)
> > compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> > reproduce:
> >          # save the attached .config to linux build tree
> >          make ARCH=x86_64
> > 
> > All errors (new ones prefixed by >>):
> > 
> >>> drivers//acpi/acpi_apd.c:14:10: fatal error: linux/platform_data/clk-st.h: No such file or directory
> >      #include <linux/platform_data/clk-st.h>
> >               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >     compilation terminated.
> > 
> 
> This patch is dependent on https://patchwork.kernel.org/patch/10370955/
> The above patch adds the required include file.

So please resend it when the requisite patch is merged and add the dependency
information to its changelog.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-01  9:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-30  7:10 [PATCH] ACPI: APD: Add AMD misc clock handler support Akshu Agrawal
2018-04-30  8:53 ` kbuild test robot
2018-04-30  9:40   ` Agrawal, Akshu
2018-05-01  9:33     ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).