LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] platform/x86: asus-wmi: Add keyboard backlight toggle support
@ 2018-05-02  6:02 Chris Chiu
  2018-05-02  6:32 ` Jian-Hong Pan
  2018-05-02 14:29 ` Puma D.
  0 siblings, 2 replies; 4+ messages in thread
From: Chris Chiu @ 2018-05-02  6:02 UTC (permalink / raw)
  To: corentin.chary, dvhart, andy
  Cc: acpi4asus-user, platform-driver-x86, linux-kernel, linux, Chris Chiu

Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard
backlight toggle. In this UX550GE, the hotkey incremet the level
of brightness for each keypress from 1 to 3, and then switch it
off when the brightness has been the max. This commit interprets
the code 0xc7 generated from hotkey to KEY_KBDILLUMUP to increment
the brightness, then pass KEY_KBDILLUMTOGGLE to user space after
the brightness max been reached for switching the led off.

https://phabricator.endlessm.com/T21390

Signed-off-by: Chris Chiu <chiu@endlessm.com>
---
 drivers/platform/x86/asus-nb-wmi.c | 1 +
 drivers/platform/x86/asus-wmi.c    | 8 ++++++++
 2 files changed, 9 insertions(+)

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 136ff2b..14c502e 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -496,6 +496,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
 	{ KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
 	{ KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
 	{ KE_IGNORE, 0xC6, },  /* Ambient Light Sensor notification */
+	{ KE_KEY, 0xC7, { KEY_KBDILLUMTOGGLE } },
 	{ KE_END, 0},
 };
 
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 1f6e68f..b64ff90 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -67,6 +67,7 @@ MODULE_LICENSE("GPL");
 #define NOTIFY_BRNDOWN_MAX		0x2e
 #define NOTIFY_KBD_BRTUP		0xc4
 #define NOTIFY_KBD_BRTDWN		0xc5
+#define NOTIFY_KBD_BRTTOGGLE		0xc7
 
 /* WMI Methods */
 #define ASUS_WMI_METHODID_SPEC	        0x43455053 /* BIOS SPECification */
@@ -1745,6 +1746,13 @@ static void asus_wmi_notify(u32 value, void *context)
 		}
 	}
 
+	if (code == NOTIFY_KBD_BRTTOGGLE) {
+		if (asus->kbd_led_wk < asus->kbd_led.max_brightness)
+			code = NOTIFY_KBD_BRTUP;
+		else
+			code = NOTIFY_KBD_BRTTOGGLE;
+	}
+
 	if (is_display_toggle(code) &&
 	    asus->driver->quirks->no_display_toggle)
 		goto exit;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/x86: asus-wmi: Add keyboard backlight toggle support
  2018-05-02  6:02 [PATCH] platform/x86: asus-wmi: Add keyboard backlight toggle support Chris Chiu
@ 2018-05-02  6:32 ` Jian-Hong Pan
  2018-05-02 14:29 ` Puma D.
  1 sibling, 0 replies; 4+ messages in thread
From: Jian-Hong Pan @ 2018-05-02  6:32 UTC (permalink / raw)
  To: Chris Chiu
  Cc: corentin.chary, dvhart, andy, acpi4asus-user,
	platform-driver-x86, linux-kernel, Linux Upstreaming Team

2018-05-02 14:02 GMT+08:00 Chris Chiu <chiu@endlessm.com>:
> Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard
> backlight toggle. In this UX550GE, the hotkey incremet the level
> of brightness for each keypress from 1 to 3, and then switch it
> off when the brightness has been the max. This commit interprets
> the code 0xc7 generated from hotkey to KEY_KBDILLUMUP to increment
> the brightness, then pass KEY_KBDILLUMTOGGLE to user space after
> the brightness max been reached for switching the led off.
>
> https://phabricator.endlessm.com/T21390
>

Tested-by: Jian-Hong Pan <jian-hong@endlessm.com>
> Signed-off-by: Chris Chiu <chiu@endlessm.com>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 1 +
>  drivers/platform/x86/asus-wmi.c    | 8 ++++++++
>  2 files changed, 9 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 136ff2b..14c502e 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -496,6 +496,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>         { KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
>         { KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
>         { KE_IGNORE, 0xC6, },  /* Ambient Light Sensor notification */
> +       { KE_KEY, 0xC7, { KEY_KBDILLUMTOGGLE } },
>         { KE_END, 0},
>  };
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 1f6e68f..b64ff90 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -67,6 +67,7 @@ MODULE_LICENSE("GPL");
>  #define NOTIFY_BRNDOWN_MAX             0x2e
>  #define NOTIFY_KBD_BRTUP               0xc4
>  #define NOTIFY_KBD_BRTDWN              0xc5
> +#define NOTIFY_KBD_BRTTOGGLE           0xc7
>
>  /* WMI Methods */
>  #define ASUS_WMI_METHODID_SPEC         0x43455053 /* BIOS SPECification */
> @@ -1745,6 +1746,13 @@ static void asus_wmi_notify(u32 value, void *context)
>                 }
>         }
>
> +       if (code == NOTIFY_KBD_BRTTOGGLE) {
> +               if (asus->kbd_led_wk < asus->kbd_led.max_brightness)
> +                       code = NOTIFY_KBD_BRTUP;
> +               else
> +                       code = NOTIFY_KBD_BRTTOGGLE;
> +       }
> +
>         if (is_display_toggle(code) &&
>             asus->driver->quirks->no_display_toggle)
>                 goto exit;
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/x86: asus-wmi: Add keyboard backlight toggle support
  2018-05-02  6:02 [PATCH] platform/x86: asus-wmi: Add keyboard backlight toggle support Chris Chiu
  2018-05-02  6:32 ` Jian-Hong Pan
@ 2018-05-02 14:29 ` Puma D.
  2018-05-03  2:40   ` Chris Chiu
  1 sibling, 1 reply; 4+ messages in thread
From: Puma D. @ 2018-05-02 14:29 UTC (permalink / raw)
  To: Chris Chiu, corentin.chary, dvhart, andy
  Cc: acpi4asus-user, platform-driver-x86, linux-kernel, linux

On 02.05.2018 08:02, Chris Chiu wrote:
> Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard
> backlight toggle. In this UX550GE, the hotkey incremet the level
> of brightness for each keypress from 1 to 3, and then switch it
> off when the brightness has been the max. This commit interprets
> the code 0xc7 generated from hotkey to KEY_KBDILLUMUP to increment
> the brightness, then pass KEY_KBDILLUMTOGGLE to user space after
> the brightness max been reached for switching the led off.
>
> https://phabricator.endlessm.com/T21390
>
> Signed-off-by: Chris Chiu <chiu@endlessm.com>
> ---
>   drivers/platform/x86/asus-nb-wmi.c | 1 +
>   drivers/platform/x86/asus-wmi.c    | 8 ++++++++
>   2 files changed, 9 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 136ff2b..14c502e 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -496,6 +496,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>   	{ KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
>   	{ KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
>   	{ KE_IGNORE, 0xC6, },  /* Ambient Light Sensor notification */
> +	{ KE_KEY, 0xC7, { KEY_KBDILLUMTOGGLE } },
>   	{ KE_END, 0},
>   };
>   
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 1f6e68f..b64ff90 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -67,6 +67,7 @@ MODULE_LICENSE("GPL");
>   #define NOTIFY_BRNDOWN_MAX		0x2e
>   #define NOTIFY_KBD_BRTUP		0xc4
>   #define NOTIFY_KBD_BRTDWN		0xc5
> +#define NOTIFY_KBD_BRTTOGGLE		0xc7
>   
>   /* WMI Methods */
>   #define ASUS_WMI_METHODID_SPEC	        0x43455053 /* BIOS SPECification */
> @@ -1745,6 +1746,13 @@ static void asus_wmi_notify(u32 value, void *context)
>   		}
>   	}
>   
> +	if (code == NOTIFY_KBD_BRTTOGGLE) {
> +		if (asus->kbd_led_wk < asus->kbd_led.max_brightness)
> +			code = NOTIFY_KBD_BRTUP;
> +		else
> +			code = NOTIFY_KBD_BRTTOGGLE;
> +	}
Did you intend the else branch to be a noop?

> +
>   	if (is_display_toggle(code) &&
>   	    asus->driver->quirks->no_display_toggle)
>   		goto exit;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/x86: asus-wmi: Add keyboard backlight toggle support
  2018-05-02 14:29 ` Puma D.
@ 2018-05-03  2:40   ` Chris Chiu
  0 siblings, 0 replies; 4+ messages in thread
From: Chris Chiu @ 2018-05-03  2:40 UTC (permalink / raw)
  To: Puma D.
  Cc: Corentin Chary, dvhart, Andy Shevchenko, acpi4asus-user,
	Platform Driver, Linux Kernel, Linux Upstreaming Team

On Wed, May 2, 2018 at 10:29 PM, Puma D. <puma.d@web.de> wrote:
> On 02.05.2018 08:02, Chris Chiu wrote:
>>
>> Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard
>> backlight toggle. In this UX550GE, the hotkey incremet the level
>> of brightness for each keypress from 1 to 3, and then switch it
>> off when the brightness has been the max. This commit interprets
>> the code 0xc7 generated from hotkey to KEY_KBDILLUMUP to increment
>> the brightness, then pass KEY_KBDILLUMTOGGLE to user space after
>> the brightness max been reached for switching the led off.
>>
>> https://phabricator.endlessm.com/T21390
>>
>> Signed-off-by: Chris Chiu <chiu@endlessm.com>
>> ---
>>   drivers/platform/x86/asus-nb-wmi.c | 1 +
>>   drivers/platform/x86/asus-wmi.c    | 8 ++++++++
>>   2 files changed, 9 insertions(+)
>>
>> diff --git a/drivers/platform/x86/asus-nb-wmi.c
>> b/drivers/platform/x86/asus-nb-wmi.c
>> index 136ff2b..14c502e 100644
>> --- a/drivers/platform/x86/asus-nb-wmi.c
>> +++ b/drivers/platform/x86/asus-nb-wmi.c
>> @@ -496,6 +496,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>>         { KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
>>         { KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
>>         { KE_IGNORE, 0xC6, },  /* Ambient Light Sensor notification */
>> +       { KE_KEY, 0xC7, { KEY_KBDILLUMTOGGLE } },
>>         { KE_END, 0},
>>   };
>>   diff --git a/drivers/platform/x86/asus-wmi.c
>> b/drivers/platform/x86/asus-wmi.c
>> index 1f6e68f..b64ff90 100644
>> --- a/drivers/platform/x86/asus-wmi.c
>> +++ b/drivers/platform/x86/asus-wmi.c
>> @@ -67,6 +67,7 @@ MODULE_LICENSE("GPL");
>>   #define NOTIFY_BRNDOWN_MAX            0x2e
>>   #define NOTIFY_KBD_BRTUP              0xc4
>>   #define NOTIFY_KBD_BRTDWN             0xc5
>> +#define NOTIFY_KBD_BRTTOGGLE           0xc7
>>     /* WMI Methods */
>>   #define ASUS_WMI_METHODID_SPEC                0x43455053 /* BIOS
>> SPECification */
>> @@ -1745,6 +1746,13 @@ static void asus_wmi_notify(u32 value, void
>> *context)
>>                 }
>>         }
>>   +     if (code == NOTIFY_KBD_BRTTOGGLE) {
>> +               if (asus->kbd_led_wk < asus->kbd_led.max_brightness)
>> +                       code = NOTIFY_KBD_BRTUP;
>> +               else
>> +                       code = NOTIFY_KBD_BRTTOGGLE;
>> +       }
>
> Did you intend the else branch to be a noop?
>

Thanks for pointing out. The 'else' does want to do nothing special but
`Brightness Toggle` as the original code. I'll modify that and submit again.

>
>> +
>>         if (is_display_toggle(code) &&
>>             asus->driver->quirks->no_display_toggle)
>>                 goto exit;
>
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-03  2:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02  6:02 [PATCH] platform/x86: asus-wmi: Add keyboard backlight toggle support Chris Chiu
2018-05-02  6:32 ` Jian-Hong Pan
2018-05-02 14:29 ` Puma D.
2018-05-03  2:40   ` Chris Chiu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).