LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH resend] qla3xxx: convert byte order of constant instead of variable
@ 2008-02-10 10:06 Marcin Slusarz
  2008-02-12 23:36 ` [PATCH resend] qla3xxx: convert byte order of constant instead ofvariable Ron Mercer
  0 siblings, 1 reply; 2+ messages in thread
From: Marcin Slusarz @ 2008-02-10 10:06 UTC (permalink / raw)
  To: netdev, linux-driver; +Cc: LKML

convert byte order of constant instead of variable
which can be done at compile time (vs run time)

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
---
 drivers/net/qla3xxx.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
index a6aeb9d..b7f7b22 100644
--- a/drivers/net/qla3xxx.c
+++ b/drivers/net/qla3xxx.c
@@ -2472,8 +2472,7 @@ static int ql_send_map(struct ql3_adapter *qdev,
 
 	if (seg_cnt == 1) {
 		/* Terminate the last segment. */
-		oal_entry->len =
-		    cpu_to_le32(le32_to_cpu(oal_entry->len) | OAL_LAST_ENTRY);
+		oal_entry->len |= cpu_to_le32(OAL_LAST_ENTRY);
 	} else {
 		oal = tx_cb->oal;
 		for (completed_segs=0; completed_segs<frag_cnt; completed_segs++,seg++) {
@@ -2530,8 +2529,7 @@ static int ql_send_map(struct ql3_adapter *qdev,
 					  frag->size);
 		}
 		/* Terminate the last segment. */
-		oal_entry->len =
-		    cpu_to_le32(le32_to_cpu(oal_entry->len) | OAL_LAST_ENTRY);
+		oal_entry->len |= cpu_to_le32(OAL_LAST_ENTRY);
 	}
 
 	return NETDEV_TX_OK;
-- 
1.5.3.7


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH resend] qla3xxx: convert byte order of constant instead ofvariable
  2008-02-10 10:06 [PATCH resend] qla3xxx: convert byte order of constant instead of variable Marcin Slusarz
@ 2008-02-12 23:36 ` Ron Mercer
  0 siblings, 0 replies; 2+ messages in thread
From: Ron Mercer @ 2008-02-12 23:36 UTC (permalink / raw)
  To: Marcin Slusarz, netdev, Linux Driver; +Cc: LKML

 

> -----Original Message-----
> From: Marcin Slusarz [mailto:marcin.slusarz@gmail.com] 
> Sent: Sunday, February 10, 2008 2:06 AM
> To: netdev@vger.kernel.org; Linux Driver
> Cc: LKML
> Subject: [PATCH resend] qla3xxx: convert byte order of 
> constant instead ofvariable
> 
> convert byte order of constant instead of variable
> which can be done at compile time (vs run time)
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> ---
>  drivers/net/qla3xxx.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
> index a6aeb9d..b7f7b22 100644
> --- a/drivers/net/qla3xxx.c
> +++ b/drivers/net/qla3xxx.c
> @@ -2472,8 +2472,7 @@ static int ql_send_map(struct ql3_adapter *qdev,
>  
>  	if (seg_cnt == 1) {
>  		/* Terminate the last segment. */
> -		oal_entry->len =
> -		    cpu_to_le32(le32_to_cpu(oal_entry->len) | 
> OAL_LAST_ENTRY);
> +		oal_entry->len |= cpu_to_le32(OAL_LAST_ENTRY);
>  	} else {
>  		oal = tx_cb->oal;
>  		for (completed_segs=0; completed_segs<frag_cnt; 
> completed_segs++,seg++) {
> @@ -2530,8 +2529,7 @@ static int ql_send_map(struct ql3_adapter *qdev,
>  					  frag->size);
>  		}
>  		/* Terminate the last segment. */
> -		oal_entry->len =
> -		    cpu_to_le32(le32_to_cpu(oal_entry->len) | 
> OAL_LAST_ENTRY);
> +		oal_entry->len |= cpu_to_le32(OAL_LAST_ENTRY);
>  	}
>  
>  	return NETDEV_TX_OK;
> -- 
> 1.5.3.7
> 
> 

Thanks

Acked-by: Ron Mercer <ron.mercer@qlogic.com> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-12 23:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-10 10:06 [PATCH resend] qla3xxx: convert byte order of constant instead of variable Marcin Slusarz
2008-02-12 23:36 ` [PATCH resend] qla3xxx: convert byte order of constant instead ofvariable Ron Mercer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).