LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Williams, Dan J" <dan.j.williams@intel.com>
To: "Andrew Morton" <akpm@linux-foundation.org>,
	"Evgeniy Polyakov" <johnpol@2ka.mipt.ru>
Cc: "Randy Dunlap" <randy.dunlap@oracle.com>,
	"lkml" <linux-kernel@vger.kernel.org>
Subject: RE: W1 printk format warning
Date: Thu, 26 Apr 2007 17:55:43 -0700	[thread overview]
Message-ID: <0C7297FA1D2D244A9C7F6959C0BF1E5201C1D359@azsmsx413.amr.corp.intel.com> (raw)
In-Reply-To: <20070426142226.891d2e9a.akpm@linux-foundation.org>

> From: Andrew Morton [mailto:akpm@linux-foundation.org]
> On Thu, 26 Apr 2007 22:17:44 +0400 Evgeniy Polyakov
<johnpol@2ka.mipt.ru>
> wrote:
> 
> > On Wed, Apr 25, 2007 at 04:45:09PM -0700, Andrew Morton (akpm@linux-
> foundation.org) wrote:
> > > On Wed, 25 Apr 2007 16:21:04 -0700 Randy Dunlap
<randy.dunlap@oracle.com>
> wrote:
> > >
> > > > in 2.6.21-rc7-mm1.  Are you aware of this?
> > > >
> > > > drivers/w1/w1.c:460: warning: too few arguments for format
> > > >
> > > > 	dev_dbg(&sl->dev, "%s: registering %s as %p.\n",
__func__,
> > > > 		&sl->dev.bus_id[0]);
> > > >
> > >
> > > Yeah, that's because Dan's dev_dbg-check-dev_dbg-arguments.patch
added
> > > printk arg-checking to dev_dbg() and a bunch of bugs got exposed.
I fixed
> > > a few of them.
> >
> > Could you post a full list for w1, if there is only one, here is a
fix.
> >
> 
> There's only the one in w1, I think.  I fixed a few more but I didn't
> actually go looking for more such errors.

Feel free to bug me if there is more fallout that is not otherwise
picked up...

--
Dan

      reply	other threads:[~2007-04-27  0:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-25 23:21 Randy Dunlap
2007-04-25 23:45 ` Andrew Morton
2007-04-26 18:17   ` Evgeniy Polyakov
2007-04-26 21:22     ` Andrew Morton
2007-04-27  0:55       ` Williams, Dan J [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0C7297FA1D2D244A9C7F6959C0BF1E5201C1D359@azsmsx413.amr.corp.intel.com \
    --to=dan.j.williams@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --subject='RE: W1 printk format warning' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).