From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F3AC4320A for ; Thu, 5 Aug 2021 08:23:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB66060EC0 for ; Thu, 5 Aug 2021 08:23:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237415AbhHEIXc (ORCPT ); Thu, 5 Aug 2021 04:23:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237469AbhHEIXX (ORCPT ); Thu, 5 Aug 2021 04:23:23 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E903FC0613C1 for ; Thu, 5 Aug 2021 01:23:09 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id p38so9608324lfa.0 for ; Thu, 05 Aug 2021 01:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+e6CGQXxPMJe6R9jF7UtUP2EM2nwkAeOu++SZ0r1h48=; b=g9Fw9rp8HJt6YVrjbNKeYQ1cxVRtK7R5x5yue0bGcwObp8XT8wnN1ueN0WXsG0n46f hJtSGe20wDlez9DuciC9s+qlj4cmcdzZ+oVIymjn3Q3IQhU7zhoft9qfOpmHlSZYhIxJ jCN/BeTXg3D3L/XQuJdM3DSCT7/P3KFXDJcYKPza+o7lLDyn2iFtMQyThi6k1g749Go9 pjt2FCuQ0EwfxacwyBIZvcZqGDT2MwhoULpYjSx0CfoCY6YYZFl9Fdp0l7mlN2eTpVCn h0IPLKTpJ0fMHtpT7TsyuuRGsE311a+5PgEy0+im9sj5WD1OOa+3+hKnyNEDVkQJ71Fz 5btQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+e6CGQXxPMJe6R9jF7UtUP2EM2nwkAeOu++SZ0r1h48=; b=ciV2uql/4k5qqQ4UN3nWOUi1qOF0+Tsk/LKPpihZOr+i7FDbGqLsPabsEn8tQaaIqv 8vcfXu2t2n1X3g2Ce5ALZ/xbgtYw9Zj/+Eu7SnGHytlEDNjBQ/sPTfRsQyP1Jvr2YpaL tGJT7FaPNzFwOcF0h+H/DGNWmw8WYAp0caCxgZ9SaWeiXrWUxpphek4vY9xtg5CmopoS KMSpUNxJylsRLxxeIHY8X7milwqw2qzQJW7IqdyHHDZyrOZiy84eJVtCEHlmFQf9oNW2 kg+w3gEsHJVobXuZfYbXVBvxeJZ2zjE8laSQZtBD8tgoR51G9vA+pJ7cQEOUA+Vr9l4l ji+g== X-Gm-Message-State: AOAM532Eila8deycUpLX3OzNEHugYhVFlc9xXlLp+vqmQaNa2jmOGBAV 1O3Icq2GseEtIV6nG4+avLpdiw== X-Google-Smtp-Source: ABdhPJy/d8s2887ufCuc62214Nvv1BektY4zjKTu/arCogjXCRDEpuyLUIGwPdFqdI23mNRuLRdaqw== X-Received: by 2002:ac2:569e:: with SMTP id 30mr2756171lfr.322.1628151787049; Thu, 05 Aug 2021 01:23:07 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id w10sm440434lfa.66.2021.08.05.01.23.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Aug 2021 01:23:06 -0700 (PDT) Subject: Re: [PATCH -next v2] drm/msm: Use list_move_tail instead of list_del/list_add_tail in msm_gem.c To: Baokun Li , linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: weiyongjun1@huawei.com, yuehaibing@huawei.com, yangjihong1@huawei.com, yukuai3@huawei.com, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, kernel-janitors@vger.kernel.org, Hulk Robot References: <20210609072838.1369371-1-libaokun1@huawei.com> From: Dmitry Baryshkov Message-ID: <0ac0b93f-65f6-930b-a224-12ebf919ad9d@linaro.org> Date: Thu, 5 Aug 2021 11:23:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210609072838.1369371-1-libaokun1@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2021 10:28, Baokun Li wrote: > Using list_move_tail() instead of list_del() + list_add_tail() in msm_gem.c. > > Reported-by: Hulk Robot > Signed-off-by: Baokun Li Reviewed-by: Dmitry Baryshkov > --- > V1->V2: > CC mailist > > drivers/gpu/drm/msm/msm_gem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c > index 1865919368f2..5b7d63d3750a 100644 > --- a/drivers/gpu/drm/msm/msm_gem.c > +++ b/drivers/gpu/drm/msm/msm_gem.c > @@ -854,8 +854,7 @@ void msm_gem_active_get(struct drm_gem_object *obj, struct msm_gpu *gpu) > mutex_lock(&priv->mm_lock); > if (msm_obj->evictable) > mark_unevictable(msm_obj); > - list_del(&msm_obj->mm_list); > - list_add_tail(&msm_obj->mm_list, &gpu->active_list); > + list_move_tail(&msm_obj->mm_list, &gpu->active_list); > mutex_unlock(&priv->mm_lock); > } > } > -- With best wishes Dmitry