LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] crypto: ccree - fix missing break in switch statement
@ 2019-02-11 18:31 Gustavo A. R. Silva
  2019-02-20 18:09 ` Gustavo A. R. Silva
  2019-02-22 11:58 ` Herbert Xu
  0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-11 18:31 UTC (permalink / raw)
  To: Gilad Ben-Yossef, Herbert Xu, David S. Miller
  Cc: linux-crypto, linux-kernel, Gustavo A. R. Silva, Kees Cook

Add missing break statement in order to prevent the code from falling
through to case S_DIN_to_DES.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: 63ee04c8b491 ("crypto: ccree - add skcipher support")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/crypto/ccree/cc_cipher.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_cipher.c
index 5e3361a363b5..d9c17078517b 100644
--- a/drivers/crypto/ccree/cc_cipher.c
+++ b/drivers/crypto/ccree/cc_cipher.c
@@ -80,6 +80,7 @@ static int validate_keys_sizes(struct cc_cipher_ctx *ctx_p, u32 size)
 		default:
 			break;
 		}
+		break;
 	case S_DIN_to_DES:
 		if (size == DES3_EDE_KEY_SIZE || size == DES_KEY_SIZE)
 			return 0;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: ccree - fix missing break in switch statement
  2019-02-11 18:31 [PATCH] crypto: ccree - fix missing break in switch statement Gustavo A. R. Silva
@ 2019-02-20 18:09 ` Gustavo A. R. Silva
  2019-02-22 11:58 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-20 18:09 UTC (permalink / raw)
  To: Gilad Ben-Yossef, Herbert Xu, David S. Miller
  Cc: linux-crypto, linux-kernel, Kees Cook

Hi all,

Friendly ping:

Who can take this?

Thanks
--
Gustavo

On 2/11/19 12:31 PM, Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from falling
> through to case S_DIN_to_DES.
> 
> This bug was found thanks to the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Fixes: 63ee04c8b491 ("crypto: ccree - add skcipher support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/crypto/ccree/cc_cipher.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_cipher.c
> index 5e3361a363b5..d9c17078517b 100644
> --- a/drivers/crypto/ccree/cc_cipher.c
> +++ b/drivers/crypto/ccree/cc_cipher.c
> @@ -80,6 +80,7 @@ static int validate_keys_sizes(struct cc_cipher_ctx *ctx_p, u32 size)
>  		default:
>  			break;
>  		}
> +		break;
>  	case S_DIN_to_DES:
>  		if (size == DES3_EDE_KEY_SIZE || size == DES_KEY_SIZE)
>  			return 0;
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: ccree - fix missing break in switch statement
  2019-02-11 18:31 [PATCH] crypto: ccree - fix missing break in switch statement Gustavo A. R. Silva
  2019-02-20 18:09 ` Gustavo A. R. Silva
@ 2019-02-22 11:58 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2019-02-22 11:58 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: Gilad Ben-Yossef, David S. Miller, linux-crypto, linux-kernel, Kees Cook

On Mon, Feb 11, 2019 at 12:31:31PM -0600, Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from falling
> through to case S_DIN_to_DES.
> 
> This bug was found thanks to the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Fixes: 63ee04c8b491 ("crypto: ccree - add skcipher support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/crypto/ccree/cc_cipher.c | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-22 11:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 18:31 [PATCH] crypto: ccree - fix missing break in switch statement Gustavo A. R. Silva
2019-02-20 18:09 ` Gustavo A. R. Silva
2019-02-22 11:58 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).