LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Aakash Hemadri <aakashhemadri123@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v5 2/3] staging: r8188eu: incorrect type in csum_ipv6_magic
Date: Sat, 28 Aug 2021 16:40:45 +0530 [thread overview]
Message-ID: <0b7d6e92c79a6daf55a0c3a4961df6f33a9bcf37.1630148641.git.aakashhemadri123@gmail.com> (raw)
In-Reply-To: <cover.1630148641.git.aakashhemadri123@gmail.com>
Fix sparse warning:
> rtw_br_ext.c:771:84: got restricted __be16 [usertype] payload_len
> rtw_br_ext.c:773:110: warning: incorrect type in argument 2
(different base types)
> rtw_br_ext.c:773:110: expected int len
> rtw_br_ext.c:773:110: got restricted __be16 [usertype] payload_len
csum_ipv6_magic and csum_partial expect int len not __be16, use
be16_to_cpu()
Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
---
drivers/staging/r8188eu/core/rtw_br_ext.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
index aa56cd1a8490..38f1bd591da9 100644
--- a/drivers/staging/r8188eu/core/rtw_br_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
@@ -615,9 +615,9 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method)
struct icmp6hdr *hdr = (struct icmp6hdr *)(skb->data + ETH_HLEN + sizeof(*iph));
hdr->icmp6_cksum = 0;
hdr->icmp6_cksum = csum_ipv6_magic(&iph->saddr, &iph->daddr,
- iph->payload_len,
+ be16_to_cpu(iph->payload_len),
IPPROTO_ICMPV6,
- csum_partial((__u8 *)hdr, iph->payload_len, 0));
+ csum_partial((__u8 *)hdr, be16_to_cpu(iph->payload_len), 0));
}
}
}
--
2.32.0
next prev parent reply other threads:[~2021-08-28 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 11:10 [PATCH v5 0/3] staging: r8188eu: fix sparse warnings Aakash Hemadri
2021-08-28 11:10 ` [PATCH v5 1/3] staging: r8188eu: restricted __be16 degrades to int Aakash Hemadri
2021-09-02 9:25 ` Greg Kroah-Hartman
2021-08-28 11:10 ` Aakash Hemadri [this message]
2021-08-28 11:37 ` [PATCH v5 2/3] staging: r8188eu: incorrect type in csum_ipv6_magic Kari Argillander
2021-08-30 10:39 ` Dan Carpenter
2021-09-02 9:27 ` Greg Kroah-Hartman
2021-08-28 11:10 ` [PATCH v5 3/3] staging: r8188eu: incorrect type in assignment Aakash Hemadri
2021-09-02 9:28 ` Greg Kroah-Hartman
2021-09-03 8:11 ` Dan Carpenter
2021-08-30 10:52 ` [PATCH v5 0/3] staging: r8188eu: fix sparse warnings Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b7d6e92c79a6daf55a0c3a4961df6f33a9bcf37.1630148641.git.aakashhemadri123@gmail.com \
--to=aakashhemadri123@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--subject='Re: [PATCH v5 2/3] staging: r8188eu: incorrect type in csum_ipv6_magic' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).