LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	bhelgaas@google.com, lorenzo.pieralisi@arm.com,
	Joao.Pinto@synopsys.com, jingoohan1@gmail.com, kishon@ti.com,
	robh+dt@kernel.org, mark.rutland@arm.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 7/9] PCI: dwc: Replace lower into upper case characters
Date: Mon, 09 Apr 2018 03:25:46 -0700	[thread overview]
Message-ID: <0dad6b43476c1a70944e3e7c245040243ddc2a04.camel@perches.com> (raw)
In-Reply-To: <a28d463d04b198f51c64c1a7eb5b3f77da2d4ab9.1523266508.git.gustavo.pimentel@synopsys.com>

On Mon, 2018-04-09 at 10:41 +0100, Gustavo Pimentel wrote:
> Replaces lower into upper case characters in comments and debug printks.
> 
> This is an attempt to keep the messages coherent within the designware
> driver.

It'd be nice to make all the dwc drivers use the same
message wording.

For instance:

drivers/pci/dwc/pci-keystone.c: dev_err(dev, "phy link never came up\n");
drivers/pci/dwc/pcie-designware.c:      dev_err(pci->dev, "phy link never came up\n");
drivers/pci/host/pcie-xilinx-nwl.c:     dev_err(dev, "PHY link never came up\n");

  reply	other threads:[~2018-04-09 10:25 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09  9:41 [PATCH v2 0/9] Designware EP support and code clean up Gustavo Pimentel
2018-04-09  9:41 ` [PATCH v2 1/9] bindings: PCI: designware: Example update Gustavo Pimentel
2018-04-09  9:41 ` [PATCH v2 2/9] PCI: dwc: Add support for endpoint mode Gustavo Pimentel
2018-04-10  5:12   ` Kishon Vijay Abraham I
2018-04-10 10:36     ` Gustavo Pimentel
2018-04-10 11:09       ` Kishon Vijay Abraham I
2018-04-09  9:41 ` [PATCH v2 3/9] bindings: PCI: designware: Add support for the EP in Designware driver Gustavo Pimentel
2018-04-09  9:41 ` [PATCH v2 4/9] PCI: Adds device ID for Synopsys Sample Endpoint Gustavo Pimentel
2018-04-09  9:41 ` [PATCH v2 5/9] misc: pci_endpoint_test: Add designware EP entry Gustavo Pimentel
2018-04-09  9:41 ` [PATCH v2 6/9] PCI: dwc: Define maximum number of vectors Gustavo Pimentel
2018-04-09 16:03   ` Lorenzo Pieralisi
2018-04-10  7:59     ` Gustavo Pimentel
2018-04-10  9:56       ` Lorenzo Pieralisi
2018-04-09  9:41 ` [PATCH v2 7/9] PCI: dwc: Replace lower into upper case characters Gustavo Pimentel
2018-04-09 10:25   ` Joe Perches [this message]
2018-04-09 13:10     ` Gustavo Pimentel
2018-04-09 14:25       ` Joe Perches
2018-04-11  0:05   ` Jingoo Han
2018-04-09  9:41 ` [PATCH v2 8/9] PCI: dwc: Small computation improvement Gustavo Pimentel
2018-04-11  0:01   ` Jingoo Han
2018-04-11  7:40     ` Gustavo Pimentel
2018-04-11 19:37       ` Jingoo Han
2018-04-16  8:41         ` Gustavo Pimentel
2018-04-15 13:09       ` Fabio Estevam
2018-04-16  8:35         ` Gustavo Pimentel
2018-04-09  9:41 ` [PATCH v2 9/9] PCI: dwc: Replace magic number by defines Gustavo Pimentel
2018-04-11  0:07   ` Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dad6b43476c1a70944e3e7c245040243ddc2a04.camel@perches.com \
    --to=joe@perches.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=jingoohan1@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).