LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Dave Hansen <dave.hansen@linux.intel.com>, linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	hpa@zytor.com, x86@kernel.org, peterz@infradead.org,
	mpe@ellerman.id.au, will.deacon@arm.com, luto@kernel.org,
	jroedel@suse.de, danielmicay@gmail.com
Subject: Re: [PATCH 1/2] x86/pkeys: copy pkey state at fork()
Date: Fri, 26 Oct 2018 12:59:55 -0700	[thread overview]
Message-ID: <0e5fd8bc-0b18-ea88-ed95-ec81a44d0783@intel.com> (raw)
In-Reply-To: <20181026195146.9C7C1136@viggo.jf.intel.com>

On 10/26/18 12:51 PM, Dave Hansen wrote:
...
> The result is that, after a fork(), the child's pkey state ends up
> looking like it does after an execve(), which is totally wrong.  pkeys
> that are already allocated can be allocated again, for instance.

One thing I omitted.  This was very nicely discovered and reported by
danielmicay@gmail.com.  Thanks, Daniel!

  parent reply	other threads:[~2018-10-26 19:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26 19:51 Dave Hansen
2018-10-26 19:51 ` [PATCH 2/2] x86/selftests/pkeys: fork() to check for state being preserved Dave Hansen
2018-10-26 19:59 ` Dave Hansen [this message]
2018-10-26 21:39   ` [PATCH 1/2] x86/pkeys: copy pkey state at fork() Daniel Micay
2018-10-26 22:12     ` Andy Lutomirski
2018-10-26 22:56       ` Daniel Micay
2018-10-29  6:36         ` Ingo Molnar
2018-10-29  8:55           ` Daniel Micay
2018-11-20 21:14   ` Kees Cook
2019-01-09  0:56     ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e5fd8bc-0b18-ea88-ed95-ec81a44d0783@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@alien8.de \
    --cc=danielmicay@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH 1/2] x86/pkeys: copy pkey state at fork()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).