LKML Archive on
help / color / mirror / Atom feed
* Re: inux should not set the "PnP OS" boot flag
@ 2001-10-06  4:32 Thomas Hood
  0 siblings, 0 replies; only message in thread
From: Thomas Hood @ 2001-10-06  4:32 UTC (permalink / raw)
  To: linux-kernel

> I append a short patch
> to remove the bit of code that sets the boot flag.  (I see where
> the function also zeroes out the sbf value if it appears not to be
> a valid value.  That seems rather rash to me, but I leave it
> alone because I don't understand why it's there.)

I see also that in that function:

static void __init sbf_bootup(void)
	u8 v = sbf_read();
		v = 0;
#if defined(CONFIG_PNPBIOS)
	/* Tell the BIOS to fast init as we are a PnP OS */
	v |= (1<<0);	/* Set PNPOS flag */

there is a parity check (in the sbf_value_valid function)
prior to changing one of the bits, but there is no check to make
sure that the parity is still correct after the "PNPOS" flag
has been set.  Is this okay?  Or am I confused about something?

Thomas Hood

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2001-10-06  4:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-10-06  4:32 inux should not set the "PnP OS" boot flag Thomas Hood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).