LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
	broonie@kernel.org, alsa-devel@alsa-project.org
Cc: Sunil-kumar.Dommati@amd.com,
	open list <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Alexander.Deucher@amd.com, krisman@collabora.com
Subject: Re: [PATCH v4 05/12] ASoC: amd: add ACP5x PCM platform driver
Date: Tue, 20 Jul 2021 13:12:55 -0500	[thread overview]
Message-ID: <106fa9e8-1d22-dd6a-8301-20761a212e4f@linux.intel.com> (raw)
In-Reply-To: <20210720163732.23003-6-Vijendar.Mukunda@amd.com>


> +static int acp5x_audio_probe(struct platform_device *pdev)
> +{
> +	struct resource *res;
> +	struct i2s_dev_data *adata;
> +	int status;
> +
> +	if (!pdev->dev.platform_data) {
> +		dev_err(&pdev->dev, "platform_data not retrieved\n");
> +		return -ENODEV;
> +	}
> +	irqflags = *((unsigned int *)(pdev->dev.platform_data));
> +
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res) {
> +		dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n");
> +			return -ENODEV;

indentation is off?

> +	}
> +
> +	adata = devm_kzalloc(&pdev->dev, sizeof(*adata), GFP_KERNEL);
> +	if (!adata)
> +		return -ENOMEM;
> +
> +	adata->acp5x_base = devm_ioremap(&pdev->dev, res->start,
> +					 resource_size(res));
> +	if (!adata->acp5x_base)
> +		return -ENOMEM;
> +	dev_set_drvdata(&pdev->dev, adata);
> +	status = devm_snd_soc_register_component(&pdev->dev,
> +						 &acp5x_i2s_component,
> +						 NULL, 0);
> +	if (status)
> +		dev_err(&pdev->dev, "Fail to register acp i2s component\n");
> +
> +	return status;
> +}

  reply	other threads:[~2021-07-20 18:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210720163732.23003-1-Vijendar.Mukunda@amd.com>
2021-07-20 16:37 ` [PATCH v4 01/12] ASoC: amd: add Vangogh ACP5x IP register header Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 02/12] ASoC: amd: add Vangogh ACP PCI driver Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 03/12] ASoc: amd: add acp5x init/de-init functions Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 04/12] ASoC: amd: create acp5x platform devices Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 05/12] ASoC: amd: add ACP5x PCM platform driver Vijendar Mukunda
2021-07-20 18:12   ` Pierre-Louis Bossart [this message]
2021-07-20 23:11     ` Mukunda,Vijendar
2021-07-20 16:37 ` [PATCH v4 06/12] ASoC: amd: irq handler changes for ACP5x PCM dma driver Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 07/12] ASoC: amd: add ACP5x pcm dma driver ops Vijendar Mukunda
2021-07-20 18:27   ` Pierre-Louis Bossart
2021-07-20 23:10     ` Mukunda,Vijendar
2021-07-20 16:37 ` [PATCH v4 08/12] ASoC: amd: add vangogh i2s controller driver Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 09/12] ASoC: amd: add vangogh i2s dai driver ops Vijendar Mukunda
2021-07-20 18:30   ` Pierre-Louis Bossart
2021-07-20 23:08     ` Mukunda,Vijendar
2021-07-20 16:37 ` [PATCH v4 10/12] ASoC: amd: add vangogh pci driver pm ops Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 11/12] ASoC: amd: add vangogh i2s dma " Vijendar Mukunda
2021-07-20 16:37 ` [PATCH v4 12/12] ASoC: amd: enable vangogh acp5x driver build Vijendar Mukunda
2021-07-20 18:31   ` Pierre-Louis Bossart
2021-07-20 23:06     ` Mukunda,Vijendar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=106fa9e8-1d22-dd6a-8301-20761a212e4f@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Sunil-kumar.Dommati@amd.com \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=krisman@collabora.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    --subject='Re: [PATCH v4 05/12] ASoC: amd: add ACP5x PCM platform driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).