From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933250AbXAYFGm (ORCPT ); Thu, 25 Jan 2007 00:06:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933249AbXAYFGm (ORCPT ); Thu, 25 Jan 2007 00:06:42 -0500 Received: from ns.suse.de ([195.135.220.2]:46736 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933241AbXAYFGk (ORCPT ); Thu, 25 Jan 2007 00:06:40 -0500 From: NeilBrown To: Andrew Morton Date: Thu, 25 Jan 2007 16:06:16 +1100 Message-Id: <1070125050616.21497@suse.de> X-face: [Gw_3E*Gng}4rRrKRYotwlE?.2|**#s9D Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org One more... (sorry about the dribs-and-drabs approach) NeilBrown ### Comments for Changeset raid5_mergeable_bvec tries to ensure that raid5 never sees a read request that does not fit within just one chunk. However as we must always accept a single-page read, that is not always possible. So when "in_chunk_boundary" fails, it might be unusual, but it is not a problem and printing a message every time is a bad idea. Signed-off-by: Neil Brown ### Diffstat output ./drivers/md/raid5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff .prev/drivers/md/raid5.c ./drivers/md/raid5.c --- .prev/drivers/md/raid5.c 2007-01-25 15:57:56.000000000 +1100 +++ ./drivers/md/raid5.c 2007-01-25 15:55:43.000000000 +1100 @@ -2630,7 +2630,7 @@ static int chunk_aligned_read(request_qu mdk_rdev_t *rdev; if (!in_chunk_boundary(mddev, raid_bio)) { - printk("chunk_aligned_read : non aligned\n"); + PRINTK("chunk_aligned_read : non aligned\n"); return 0; } /*