LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 2.6.6-mm2] i8042 debug broken
@ 2004-05-14 11:09 FabF
  2004-05-29  8:12 ` Vojtech Pavlik
  0 siblings, 1 reply; 2+ messages in thread
From: FabF @ 2004-05-14 11:09 UTC (permalink / raw)
  To: lkml; +Cc: Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 108 bytes --]

Hi,

	i8042 handle_data debug was broken -trying to display unknown
irq-.Here's a quick fix.

Regards,
FabF

[-- Attachment #2: i80421.diff --]
[-- Type: text/x-patch, Size: 929 bytes --]

diff -Naur orig/drivers/input/serio/i8042.c edited/drivers/input/serio/i8042.c
--- orig/drivers/input/serio/i8042.c	2004-05-14 12:40:49.000000000 +0200
+++ edited/drivers/input/serio/i8042.c	2004-05-14 12:56:48.000000000 +0200
@@ -420,16 +420,16 @@
 				data = 0xfe;
 			} else dfl = 0;
 
-			dbg("%02x <- i8042 (interrupt, aux%d, %d%s%s)",
-				data, (str >> 6), irq,
+			dbg("%02x <- i8042 (interrupt, aux%d, %s%s)",
+				data, (str >> 6), 
 				dfl & SERIO_PARITY ? ", bad parity" : "",
 				dfl & SERIO_TIMEOUT ? ", timeout" : "");
 
 			serio_interrupt(i8042_mux_port + ((str >> 6) & 3), data, dfl, NULL);
 		} else {
 
-			dbg("%02x <- i8042 (interrupt, %s, %d%s%s)",
-				data, (str & I8042_STR_AUXDATA) ? "aux" : "kbd", irq,
+			dbg("%02x <- i8042 (interrupt, %s, %s%s)",
+				data, (str & I8042_STR_AUXDATA) ? "aux" : "kbd",
 				dfl & SERIO_PARITY ? ", bad parity" : "",
 				dfl & SERIO_TIMEOUT ? ", timeout" : "");
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2.6.6-mm2] i8042 debug broken
  2004-05-14 11:09 [PATCH 2.6.6-mm2] i8042 debug broken FabF
@ 2004-05-29  8:12 ` Vojtech Pavlik
  0 siblings, 0 replies; 2+ messages in thread
From: Vojtech Pavlik @ 2004-05-29  8:12 UTC (permalink / raw)
  To: FabF; +Cc: lkml, Andrew Morton

On Fri, May 14, 2004 at 01:09:51PM +0200, FabF wrote:
> Hi,
> 
> 	i8042 handle_data debug was broken -trying to display unknown
> irq-.Here's a quick fix.

I reverted the tasklet conversion of i8042. It should be OK now. And
also you shouldn't have a dead keyboard after you press CapsLock. 
That was likely what your cat did.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-05-29  8:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-14 11:09 [PATCH 2.6.6-mm2] i8042 debug broken FabF
2004-05-29  8:12 ` Vojtech Pavlik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).