LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Dillow <dave@thedillows.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Eric BENARD / Free <ebenard@free.fr>,
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	webvenza@libero.it, dominik.karall@gmx.net
Subject: Re: 2.6.6 : bad PCI device ID for SiS ISA bridge => SiS900 eth0: Can not find ISA bridge
Date: 16 May 2004 23:50:14 -0400	[thread overview]
Message-ID: <1084765814.32116.20.camel@ori.thedillows.org> (raw)
In-Reply-To: <40A7E161.5060207@pobox.com>

On Sun, 2004-05-16 at 17:47, Jeff Garzik wrote:
> Eric BENARD / Free wrote:
> > 1- bad PCI device ID for SiS ISA bridge
> > 
> > 2- In 2.6.3-rc2 (and 2.4.x), the PCI device ID of the ISA bridge of the 
> > SiS630e is 0x0008. This ID is used by sis900.c in order to get the MAC 
> > adress. 
> > In 2.6.6, the PCI device ID of the ISA bridge of the SiS630E is 0x0018. The 
> > SiS900 driver fail to read MAC adress and exit with the following message : 
> > eth0: Can not find ISA bridge
> [...]
[...]
> I'm not sure I understand your message.
> 
> Are you suggesting
> a) the hardware PCI id changed from 0x0008 to 0x0018 when booting 2.6.6.
> 	or
> b) sis900.c changed when booting 2.6.6.
> 
> If "a", the PCI id in sis900.c seems to be 0x0008 in both 2.4 and 2.6. 
> And further, I did not see any changes to this line of code in while 
> searching 2.6.2 -> 2.6.6 patches on ftp.kernel.org.  I would lean 
> towards a solution that modified sis900.c to check for -both- 0x08 and 0x18.

I'm not sure I understand the message, either. I can confirm that SiS's
LPC-to-ISA bridges can change their device ID based on writes to the PCI
config space -- 0x08 and 0x18 are both valid ids for that hardware.

Eric, if you'll send me an lspci -xxx on the ISA bridge run under both
kernels, that may be interesting. Then the fun part will be finding what
changed in the kernel to cause that.

In any event, I think it would be valid to have sis900 check for both
ids.

Dave

  reply	other threads:[~2004-05-17  3:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-16 18:04 Eric BENARD / Free
2004-05-16 21:47 ` Jeff Garzik
2004-05-17  3:50   ` David Dillow [this message]
2004-05-17  6:48     ` Eric BENARD / Free
2004-05-17  6:29   ` Eric BENARD / Free
2004-05-17 10:00     ` Daniele Venzano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1084765814.32116.20.camel@ori.thedillows.org \
    --to=dave@thedillows.org \
    --cc=akpm@osdl.org \
    --cc=dominik.karall@gmx.net \
    --cc=ebenard@free.fr \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=webvenza@libero.it \
    --subject='Re: 2.6.6 : bad PCI device ID for SiS ISA bridge => SiS900 eth0: Can not find ISA bridge' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).