LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christophe Saout <christophe@saout.de>
To: Chris Wright <chrisw@sous-sol.org>
Cc: linux-kernel@vger.kernel.org, dm-crypt@saout.de,
	Andrey <dm-crypt-revealed-address@lelik.org>,
	Andrew Morton <akpm@osdl.org>,
	agk@redhat.com, Neil Brown <neilb@suse.de>,
	Jens Axboe <jens.axboe@oracle.com>,
	stable@kernel.org
Subject: Re: [stable][PATCH < 2.6.19] Fix data corruption with dm-crypt over RAID5
Date: Sat, 02 Dec 2006 12:00:48 +0100	[thread overview]
Message-ID: <1165057248.15095.9.camel@leto.intern.saout.de> (raw)
In-Reply-To: <20061202034947.GE6602@sequoia.sous-sol.org>

[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]

Am Freitag, den 01.12.2006, 19:49 -0800 schrieb Chris Wright:

> * Christophe Saout (christophe@saout.de) wrote:
> > Fix corruption issue with dm-crypt on top of software raid5. Cancelled
> > readahead bio's that report no error, just have BIO_UPTODATE cleared
> > were reported as successful reads to the higher layers (and leaving
> > random content in the buffer cache). Already fixed in 2.6.19.
> 
> I take it this is fixed a different way in 2.6.19?  Mind clarifying the
> difference?

It's more or less fixed the same way in 2.6.19. The function was
reordered by Milan Broz to accommodate the changed write path (commit
8b004457168995f2ae2a35327f885183a9e74141):

> [PATCH] dm crypt: restructure for workqueue change
>
> Restructure part of the dm-crypt code in preparation for workqueue
> changes.
>
> Use 'base_bio' or 'clone' variable names consistently throughout.  No
> functional changes are included in this patch.

"No functional changes" actually included the correct fix, accidental or
not.

> Minor nit:  introduces trailing whitespaces, cleaned it up locally.

Ouch, sorry.


[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2006-12-02 11:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <456B732F.6080906@lelik.org>
     [not found] ` <20061129145208.GQ4409@agk.surrey.redhat.com>
     [not found]   ` <456F46E3.6030702@lelik.org>
     [not found]     ` <1164983209.24524.20.camel@leto.intern.saout.de>
     [not found]       ` <20061201152143.GE4409@agk.surrey.redhat.com>
     [not found]         ` <45704B95.3020308@lelik.org>
     [not found]           ` <1165026116.29307.18.camel@leto.intern.saout.de>
2006-12-02  2:27             ` Christophe Saout
2006-12-02  3:49               ` Chris Wright
2006-12-02 11:00                 ` Christophe Saout [this message]
2007-01-17  8:44               ` [dm-devel] " Piet Delaney
2007-02-23  2:49               ` Piet Delaney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1165057248.15095.9.camel@leto.intern.saout.de \
    --to=christophe@saout.de \
    --cc=agk@redhat.com \
    --cc=akpm@osdl.org \
    --cc=chrisw@sous-sol.org \
    --cc=dm-crypt-revealed-address@lelik.org \
    --cc=dm-crypt@saout.de \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=stable@kernel.org \
    --subject='Re: [stable][PATCH < 2.6.19] Fix data corruption with dm-crypt over RAID5' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).