LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com> To: ltuikov@yahoo.com Cc: Andrew Morton <akpm@osdl.org>, mdr@sgi.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Infinite retries reading the partition table Date: Thu, 07 Dec 2006 15:15:03 -0600 [thread overview] Message-ID: <1165526103.4698.50.camel@mulgrave.il.steeleye.com> (raw) In-Reply-To: <367656.23632.qm@web31810.mail.mud.yahoo.com> On Thu, 2006-12-07 at 11:14 -0800, Luben Tuikov wrote: > It is. If good_bytes=0 then nothing is up to date and uptodate should > be set to 0. That's not a correct assumption. Zero transfer commands, like TEST UNIT READY are perfectly happy to complete successfully with good_bytes == 0. > Look at my comment before the function call: > /* A number of bytes were successfully read. ... > > I repeat again: it doesn't make sense to call scsi_end_request > with uptodate=1 and good_bytes=0, since _no bytes are uptodate_. We can certainly debate that, but it's not appropriate to do it as part of an unrelated patch. James
next prev parent reply other threads:[~2006-12-07 21:15 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2006-11-30 1:22 Infinite retries reading the partition table Luben Tuikov 2006-12-01 5:47 ` Andrew Morton 2006-12-01 6:34 ` Luben Tuikov 2006-12-01 7:29 ` Andrew Morton 2006-12-01 8:32 ` Luben Tuikov 2006-12-05 20:40 ` Michael Reed 2006-12-06 5:00 ` Luben Tuikov 2006-12-06 5:08 ` Andrew Morton 2006-12-06 6:10 ` Luben Tuikov 2006-12-06 15:59 ` James Bottomley 2006-12-06 20:24 ` Luben Tuikov 2006-12-07 18:16 ` James Bottomley 2006-12-07 19:14 ` Luben Tuikov 2006-12-07 21:15 ` James Bottomley [this message] 2006-12-06 10:48 ` Etienne.Vogt 2006-11-30 1:53 Luben Tuikov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1165526103.4698.50.camel@mulgrave.il.steeleye.com \ --to=james.bottomley@steeleye.com \ --cc=akpm@osdl.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=ltuikov@yahoo.com \ --cc=mdr@sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).