LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andreas Schwab <schwab@suse.de>
Cc: linux1394-devel@lists.sourceforge.net, linuxppc-dev@ozlabs.org,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.20-rc2: kernel BUG at include/asm/dma-mapping.h:110!
Date: Sat, 30 Dec 2006 08:52:51 +1100 [thread overview]
Message-ID: <1167429171.23340.125.camel@localhost.localdomain> (raw)
In-Reply-To: <je7iwa1l8a.fsf@sykes.suse.de>
> Bisecting has identified this commit:
>
> commit 9b7d9c096dd4e4baacc21b2588662bbb56f36c4e
> Author: Stefan Richter <stefanr@s5r6.in-berlin.de>
> Date: Wed Nov 22 21:44:34 2006 +0100
>
> ieee1394: sbp2: convert from PCI DMA to generic DMA
>
> API conversion without change in functionality
>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
>
>
> I'm only seeing this on ppc64, ppc32 seems to be working fine.
The patch looks totally bogus to me. It's passing a random struct device
from the hbsp host data structure to the dma_map_* routines. which they
can't do anything about.
The dma_map_* routines only know about some bus types. That's always
been the case (that's why you also can't pass a usb device's struct
device to them for example). Mostly, PCI, possibly others depending on
the platform.
So if you are to pass a struct device pointer to dma_map_*, use the one
inside the pci_dev of the host. Or have the host driver provide you with
the struct device pointer (which is the one from the pci_dev * for PCI
implementations, and others give you what they are on, assuming the
platform can do dma-* on that device).
Ben.
next parent reply other threads:[~2006-12-29 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <je7iwa1l8a.fsf@sykes.suse.de>
2006-12-29 21:52 ` Benjamin Herrenschmidt [this message]
2006-12-29 22:47 ` Stefan Richter
2006-12-30 12:41 ` Andreas Schwab
[not found] ` <1167550089.12593.11.camel@melchior>
[not found] ` <jey7oowgdo.fsf@sykes.suse.de>
[not found] ` <1167708109.12382.26.camel@melchior>
[not found] ` <459A800E.3010604@s5r6.in-berlin.de>
2007-01-02 16:31 ` Stefan Richter
2007-01-18 20:28 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1167429171.23340.125.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=schwab@suse.de \
--cc=stefanr@s5r6.in-berlin.de \
--subject='Re: 2.6.20-rc2: kernel BUG at include/asm/dma-mapping.h:110'\!'' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).