LKML Archive on
help / color / mirror / Atom feed
Subject: agpgart: drm-populated memory types
Date: Mon, 08 Jan 2007 10:33:37 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Dave and Arjan,

I'm resending a slightly reworked version of the apgart patch for drm-populated
memory types.

The address- based vmalloc / vfree has been replaced and encapsulated in
agp-vkmalloc / agp vkfree which both takes a flag argument to indicate
whether to use vmalloc or kmalloc. This, at least, gets rid of the 
portability problem, and the chances of running into trouble in the future
will be small if all allocs / frees of these memory areas are done using
these functions.

A short recap why I belive the kmalloc / vmalloc construct is necessary:

0) The current code uses vmalloc only.
1) The allocated area ranges from 4 bytes possibly up to 512 kB, depending on
on the size of the AGP buffer allocated.
2) Large buffers are very few. Small buffers tend to be quite many. 
   If we continue to use vmalloc only or another page-based scheme we will
   waste approx one page per buffer, together with the added slowness of
   vmalloc. This will severely hurt applications with a lot of small
   texture buffers.

Please let me know if you still consider this unacceptable. 
In that case I suggest sticking with vmalloc for now.

Also please let me know if there are other parths of the patch that should be

The patch that follows is against Dave's agpgart repo.



  parent reply	other threads:[~2007-01-08 12:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-08 18:24 [patch 1/2] agpgart - allow user-populated " Thomas Hellström
2006-12-08 22:03 ` Arjan van de Ven
2006-12-08 22:17 ` Arjan van de Ven
2006-12-08 23:05   ` Thomas Hellström
2006-12-19  8:47     ` Arjan van de Ven
2006-12-19  9:44       ` Thomas Hellström
2006-12-19 12:17         ` Arjan van de Ven
2006-12-19 12:47           ` Thomas Hellström
2006-12-19 13:11             ` Arjan van de Ven
2006-12-19 14:11               ` Thomas Hellström
2007-01-08  9:33               ` thomas [this message]
2007-01-09  2:37                 ` agpgart: drm-populated " Arjan van de Ven
2007-01-09  8:28                   ` Thomas Hellström
2007-01-09  8:23                 ` [PATCH] agpgart: Allow drm-populated agp " thomas
2007-01-09 14:05                   ` Arjan van de Ven
2007-01-09 14:06                   ` Arjan van de Ven
2007-01-23  9:33                     ` New patch: drm-populated " thomas
2007-01-23  9:33                       ` [PATCH] agpgart: Allow drm-populated agp " thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: agpgart: drm-populated memory types' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).