LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: thomas@tungstengraphics.com
Cc: davej@redhat.com, linux-kernel@vger.kernel.org, arlied@gmail.com
Subject: Re: [PATCH] agpgart: Allow drm-populated agp memory types
Date: Tue, 09 Jan 2007 06:06:58 -0800	[thread overview]
Message-ID: <1168351618.3180.274.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <11683309992144-git-send-email-thomas@tungstengraphics.com>

> +
> +	agp_vkmalloc(alloc_size, &new->memory, &new->vmalloc_flag);


ok why wouldn't agp_vkmalloc take a size and just only "new" as argument
here? Just pass it a pointer to the struct it fills in anyway...

-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org


  parent reply	other threads:[~2007-01-09 14:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-08 18:24 [patch 1/2] agpgart - allow user-populated " Thomas Hellström
2006-12-08 22:03 ` Arjan van de Ven
2006-12-08 22:17 ` Arjan van de Ven
2006-12-08 23:05   ` Thomas Hellström
2006-12-19  8:47     ` Arjan van de Ven
2006-12-19  9:44       ` Thomas Hellström
2006-12-19 12:17         ` Arjan van de Ven
2006-12-19 12:47           ` Thomas Hellström
2006-12-19 13:11             ` Arjan van de Ven
2006-12-19 14:11               ` Thomas Hellström
2007-01-08  9:33               ` agpgart: drm-populated " thomas
2007-01-09  2:37                 ` Arjan van de Ven
2007-01-09  8:28                   ` Thomas Hellström
2007-01-09  8:23                 ` [PATCH] agpgart: Allow drm-populated agp " thomas
2007-01-09 14:05                   ` Arjan van de Ven
2007-01-09 14:06                   ` Arjan van de Ven [this message]
2007-01-23  9:33                     ` New patch: drm-populated " thomas
2007-01-23  9:33                       ` [PATCH] agpgart: Allow drm-populated agp " thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1168351618.3180.274.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=arlied@gmail.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas@tungstengraphics.com \
    --subject='Re: [PATCH] agpgart: Allow drm-populated agp memory types' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).