LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: Alex Tomas <alex@clusterfs.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race
Date: Fri, 12 Jan 2007 15:24:39 -0600	[thread overview]
Message-ID: <1168637079.10036.2.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <m34pqw0xii.fsf@bzzz.home.net>

On Sat, 2007-01-13 at 00:02 +0300, Alex Tomas wrote:
> interesting ..
> 
> I thought VFS doesn't allow concurrent operations.
> if unlink goes first, then link should wait on the
> parent's i_mutex and then found no source name.

I don't think the VFS ever takes the source's parent's i_mutex.  Unless
the source and destination's parent is the same, in which case the
i_mutex is taken after the source has already been looked up.

> thanks, Alex
> 
> >>>>> Eric Sandeen (ES) writes:
> 
>  ES> )
>  ES> I've been looking at a case where many threads are opening, unlinking, and
>  ES> hardlinking files on ext3 .  At unmount time I see an oops, because the superblock's
>  ES> orphan list points to a freed inode.
> 
>  ES> I did some tracing of the inodes, and it looks like this:
> 
>  ES>   ext3_unlink():[/src/linux-2.6.18/fs/ext3/namei.c:2123] adding orphan
>  ES>       i_state:0x7 cpu:1 i_count:2 i_nlink:0
> 
>  ES>   ext3_orphan_add():[/src/linux-2.6.18/fs/ext3/namei.c:1890] ext3_orphan_add
>  ES>       i_state:0x7 cpu:1 i_count:2 i_nlink:0
> 
>  ES>   iput():[/src/linux-2.6.18/fs/inode.c:1139] iput enter
>  ES>       i_state:0x7 cpu:1 i_count:2 i_nlink:0
> 
>  ES>   ext3_link():[/src/linux-2.6.18/fs/ext3/namei.c:2202] ext3_link enter
>  ES>       i_state:0x7 cpu:3 i_count:1 i_nlink:0
> 
>  ES>   ext3_inc_count():[/src/linux-2.6.18/fs/ext3/namei.c:1627] done
>  ES>       i_state:0x7 cpu:3 i_count:1 i_nlink:1
> 
>  ES> The unlink gets there first, finds i_count > 0 (in use) but nlink goes to 0, so
>  ES> it puts it on the orphan inode list.  Then link comes along, and bumps the link
>  ES> back up to 1.  So now we are on the orphan inode list, but we are not unlinked.
> 
>  ES> Eventually when count goes to 0, and we still have 1 link, again no action is
>  ES> taken to remove the inode from the orphan list, because it is still linked (i.e.
>  ES> we don't go through ext3_delete())
> 
>  ES> When this inode is eventually freed, the sb orphan list gets corrupted, because 
>  ES> we have freed it without first removing it from the orphan list.
> 
>  ES> I think the simple solution is to remove the inode from the orphan list
>  ES> when we bump the link back up from 0 to 1.  I put that test in there because
>  ES> there are other potential reasons that we might be on the list (truncates,
>  ES> direct IO).
> 
>  ES> Comments?
> 
>  ES> Thanks,
>  ES> -Eric
> 
>  ES> p.s. ext3_inc_count and ext3_dec_count seem misnamed, have an unused
>  ES> arg, and are very infrequently called.  I'll probably submit a patch
>  ES> to just put the single line of code into the caller, too.
> 
>  ES> ---
> 
>  ES> Remove inode from the orphan list in ext3_link() if we might have
>  ES> raced with ext3_unlink(), which potentially put it on the list.
>  ES> If we're on the list with nlink > 0, we'll never get cleaned up
>  ES> properly and eventually may corrupt the list.
> 
>  ES> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> 
>  ES> Index: linux-2.6.19/fs/ext3/namei.c
>  ES> ===================================================================
>  ES> --- linux-2.6.19.orig/fs/ext3/namei.c
>  ES> +++ linux-2.6.19/fs/ext3/namei.c
>  ES> @@ -2204,6 +2204,9 @@ retry:
>  inode-> i_ctime = CURRENT_TIME_SEC;
>  ES>  	ext3_inc_count(handle, inode);
>  ES>  	atomic_inc(&inode->i_count);
>  ES> +	/* did we race w/ unlink? */
>  ES> +	if (inode->i_nlink == 1)
>  ES> +		ext3_orphan_del(handle, inode);
>  
>  ES>  	err = ext3_add_nondir(handle, dentry, inode);
>  ES>  	ext3_journal_stop(handle);

-- 
David Kleikamp
IBM Linux Technology Center


  parent reply	other threads:[~2007-01-12 21:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-12 20:45 Eric Sandeen
2007-01-12 21:02 ` Alex Tomas
2007-01-12 21:14   ` Eric Sandeen
2007-01-12 21:25     ` Alex Tomas
2007-01-12 21:48       ` Eric Sandeen
2007-01-12 21:55         ` Alex Tomas
2007-01-12 22:01           ` Eric Sandeen
2007-01-12 22:07             ` Alex Tomas
2007-01-12 22:35         ` Eric Sandeen
2007-01-12 21:17   ` Alex Tomas
2007-01-12 21:24   ` Dave Kleikamp [this message]
2007-01-14 11:58 ` Dmitriy Monakhov
2007-01-14 15:42   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1168637079.10036.2.camel@kleikamp.austin.ibm.com \
    --to=shaggy@linux.vnet.ibm.com \
    --cc=alex@clusterfs.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --subject='Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).